Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataSpreadsheet]: Something is hardcoded for Column Index 1 to not read the proper value datatype #5617

Closed
2 tasks done
AustinGitHub opened this issue Jun 27, 2024 · 2 comments · Fixed by #5619
Closed
2 tasks done
Assignees
Labels
Sev 2 Aspects of design is broken and impedes users in a significant way, but has workaround. type: bug 🐛 Something isn't working

Comments

@AustinGitHub
Copy link
Contributor

Package

Carbon for IBM Products

Description

On our end

Screen.Recording.2024-06-27.at.10.35.39.AM.mov

One correlation I can make is in all the stories the column index 1 is all Row Index with integer datatype. I think there is something hardcoded on carbon products side to where when we have Column Index 1 if it isn't integer it will return undefined.

This issue came from the conversion of js to tsx. So maybe some strict rule is being applied in tsx that cause this issue for us. Hi @amal-k-joy I saw you worked on the conversion for this component. I am going to investigate and see if I can fix, but just wanted to let you know in case if maybe you have understanding of what is occurring. Thanks!

Component(s) impacted

Dataspreadsheets

Browser

Chrome

@carbon/ibm-products (previously @carbon/ibm-cloud-cognitive) version

2.39.0

Suggested Severity

Severity 2 = Aspects of design is broken, and impedes users in a significant way, but there is a way to complete their tasks. Affects major functionality, has a workaround.

Product/offering

IBM DataStage

CodeSandbox or Stackblitz example

https://carbon-for-ibm-products.netlify.app/?path=/story/ibm-products-components-data-spreadsheet-dataspreadsheet--large-dataset-spreadsheet-custom&globals=viewport:basic

Steps to reproduce the issue (if applicable)

I need to investigate further, but I believe because in the story it is Row Index, there is some datatype detection issue being made.

The storybook can sort of be replicated to my video I posted above, for example when we double click into row index, we see that it shows empty. That is similar to what I see on my implementation except it should treat this column as a string rather than an integer column.

Release date (if applicable)

We will need this to be in patch as soon as possible. If my understanding is correct, then we shouldn't be expecting user to always have Column index 1 as an integer column but treat it as any type of column they want, string or integer, etc. I am not 100% sure on this yet which is why I need to investigate.

Code of Conduct

@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Jun 27, 2024
@AustinGitHub AustinGitHub changed the title [DataSpreadsheet]: Something is hardcoded for Column Index 0 to not read the proper value datatype [DataSpreadsheet]: Something is hardcoded for Column Index 1 to not read the proper value datatype Jun 27, 2024
@AustinGitHub
Copy link
Contributor Author

Screen.Recording.2024-06-27.at.12.45.09.PM.mov

This is reproducible

@matthewgallo matthewgallo self-assigned this Jun 27, 2024
@matthewgallo matthewgallo added type: bug 🐛 Something isn't working Sev 2 Aspects of design is broken and impedes users in a significant way, but has workaround. and removed status: needs triage 🕵️‍♀️ labels Jun 27, 2024
@matthewgallo matthewgallo moved this from Needs triage 🧐 to In progress in Carbon for IBM Products Jun 27, 2024
@matthewgallo matthewgallo moved this from In progress to Needs review 👋 in Carbon for IBM Products Jun 28, 2024
@matthewgallo
Copy link
Member

Included as part of 2.45.0-rc.1.

@github-project-automation github-project-automation bot moved this from Needs review 👋 to Done 🚀 in Carbon for IBM Products Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sev 2 Aspects of design is broken and impedes users in a significant way, but has workaround. type: bug 🐛 Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants