Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CreateTearsheet]: The step content does not take into account the padding anymore #5613

Closed
2 tasks done
pascalruault opened this issue Jun 27, 2024 · 0 comments · Fixed by #6111
Closed
2 tasks done
Assignees
Labels
component: CreateTearsheet Create flows role: dev Sev 4 Not visible to or noticeable to users. Affects minor functionality, no workaround needed. type: bug 🐛 Something isn't working

Comments

@pascalruault
Copy link

pascalruault commented Jun 27, 2024

Package

Carbon for IBM Products

Description

After updating ibm-products to 2.43.1, we have noticed a layout regression in the CreateTearsheet component. Indeed, the padding-bottom around the element with the class attribute c4p--tearsheet-create__content is no more taken into account. This regression was introduced by this PR. See section "Steps to reproduce the issue".

As a workaround, we use in our app the following css rule.

.c4p--tearsheet-create__step > div:last-of-type {
  margin-bottom: 1.5rem;
}

Component(s) impacted

CreateTearsheet
CreateTearsheetStep

Browser

Chrome

@carbon/ibm-products (previously @carbon/ibm-cloud-cognitive) version

2.43.1

Suggested Severity

Severity 4 = The problem is not visible to or noticeable to an average user. Affects minor functionality, no workaround needed.

Product/offering

IBM Event Automation

CodeSandbox or Stackblitz example

https://carbon-for-ibm-products.netlify.app/?path=/story/ibm-products-patterns-create-flows-createtearsheet--with-intro-step&globals=viewport:basic

Steps to reproduce the issue (if applicable)

You can reproduce with the storyboook. See video below.

CreateTearsheet_issue_780.mov

Release date (if applicable)

No response

Code of Conduct

@github-project-automation github-project-automation bot moved this to Needs triage 🧐 in Carbon for IBM Products Jun 27, 2024
@matthewgallo matthewgallo moved this from Needs triage 🧐 to Backlog 🌋 in Carbon for IBM Products Jul 1, 2024
@matthewgallo matthewgallo added Sev 3 Visible or noticeable to users but does not impede functionality. Has a workaround. Sev 4 Not visible to or noticeable to users. Affects minor functionality, no workaround needed. and removed Sev 3 Visible or noticeable to users but does not impede functionality. Has a workaround. labels Sep 11, 2024
@davidmenendez davidmenendez self-assigned this Sep 24, 2024
@github-project-automation github-project-automation bot moved this from In review 👀 to Done 🚀 in Carbon for IBM Products Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: CreateTearsheet Create flows role: dev Sev 4 Not visible to or noticeable to users. Affects minor functionality, no workaround needed. type: bug 🐛 Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants