From f09bc26912ac7a5acb79281b299e818a66afb12d Mon Sep 17 00:00:00 2001 From: baraaabdelsalam Date: Mon, 2 Sep 2024 16:36:48 +0200 Subject: [PATCH] fix(CreateFullPage): header height to work properly on older browsers --- .../src/__tests__/__snapshots__/styles.test.js.snap | 7 +++++-- .../src/components/CreateFullPage/_create-full-page.scss | 3 +-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/ibm-products-styles/src/__tests__/__snapshots__/styles.test.js.snap b/packages/ibm-products-styles/src/__tests__/__snapshots__/styles.test.js.snap index 551413cec5..97ea88fc06 100644 --- a/packages/ibm-products-styles/src/__tests__/__snapshots__/styles.test.js.snap +++ b/packages/ibm-products-styles/src/__tests__/__snapshots__/styles.test.js.snap @@ -2126,10 +2126,9 @@ p.c4p--about-modal__copyright-text:first-child { display: grid; height: 100%; color: var(--cds-text-primary, #161616); - grid-template-rows: minmax(auto, 100%); } .c4p--create-full-page:has(.c4p--create-full-page__header) { - grid-template-rows: auto minmax(auto, 100%); + grid-template-rows: auto minmax(min-content, 100%); } .c4p--create-full-page .c4p--create-full-page__content .cds--grid { @@ -3982,6 +3981,10 @@ p.c4p--about-modal__copyright-text:first-child { padding: 0; } +.c4p--datagrid .cds--noLabel svg.cds--btn__icon { + margin-inline-start: 0; +} + .c4p--datagrid .cds--action-list .cds--btn__icon { margin-top: 0; } diff --git a/packages/ibm-products-styles/src/components/CreateFullPage/_create-full-page.scss b/packages/ibm-products-styles/src/components/CreateFullPage/_create-full-page.scss index fca2991111..2624f22e40 100644 --- a/packages/ibm-products-styles/src/components/CreateFullPage/_create-full-page.scss +++ b/packages/ibm-products-styles/src/components/CreateFullPage/_create-full-page.scss @@ -25,10 +25,9 @@ $step-block-class: #{c4p-settings.$pkg-prefix}--create-full-page__step; display: grid; height: 100%; color: $text-primary; - grid-template-rows: minmax(auto, 100%); &:has(.#{$block-class}__header) { - grid-template-rows: auto minmax(auto, 100%); + grid-template-rows: auto minmax(min-content, 100%); } }