Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(web-components): add testing setup #18537

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented Feb 6, 2025

Closes #18528
Closes #18529

{{short description}}

Changelog

New

-added web component testing to root

  • new packages
  • one simple accordion test

Removed

  • removed unneeded testing files from packages/web-components
  • kept packages/web-components/tests/spec & snapshots incase we want to reference

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit ce6f6b5
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67a4ef1b1e6cae0008de7e4d
😎 Deploy Preview https://deploy-preview-18537--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit ce6f6b5
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67a4ef1ba73c370008a2fd89
😎 Deploy Preview https://deploy-preview-18537--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit ce6f6b5
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67a4ef1b94e9030008607021
😎 Deploy Preview https://deploy-preview-18537--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit c50ea93
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67acb7742f51d700072fc0ef
😎 Deploy Preview https://deploy-preview-18537--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c50ea93
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67acb774b94769000874e399
😎 Deploy Preview https://deploy-preview-18537--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit c50ea93
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67acb774a24782000838b22d
😎 Deploy Preview https://deploy-preview-18537--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ariellalgilmore ariellalgilmore marked this pull request as ready for review February 11, 2025 18:35
@ariellalgilmore ariellalgilmore requested review from a team as code owners February 11, 2025 18:35
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.96%. Comparing base (d100cac) to head (c50ea93).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18537      +/-   ##
==========================================
+ Coverage   84.01%   84.96%   +0.94%     
==========================================
  Files         408      408              
  Lines       14477    14477              
  Branches     4718     4714       -4     
==========================================
+ Hits        12163    12300     +137     
+ Misses       2146     2016     -130     
+ Partials      168      161       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little clean up, otherwise LGTM!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably remove all the comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants