Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): ai label revert error warning divider styles #18405

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Jan 22, 2025

Closes #18116

Fix styling bugs present in number input, fluid number input, text area and fluid select when error/warning states are combined with the AiLabel and AiLabel revert.

Changelog

  • fix alignment of divider in NumberInput
  • remove extra divider FluidNumberInput
  • remove extra divider in FluidSelect
  • fix overlapping error icon and revert button on TextArea

Testing / Reviewing

Check number input, fluid number input, text area and fluid select components:

Go to the Form > With AI Label story
Check invalid state
Check warning state
Check revertActive
Check revertActive with invalid
Check revertActive with warning

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit a78ce42
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/679141cb654a5b00084ae598
😎 Deploy Preview https://deploy-preview-18405--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a78ce42
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/679141cb905995000888123e
😎 Deploy Preview https://deploy-preview-18405--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit a78ce42
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/679141cb6af9070008e5aafd
😎 Deploy Preview https://deploy-preview-18405--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (f53c551) to head (a78ce42).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18405   +/-   ##
=======================================
  Coverage   84.17%   84.17%           
=======================================
  Files         408      408           
  Lines       14435    14435           
  Branches     4640     4690   +50     
=======================================
  Hits        12150    12150           
  Misses       2121     2121           
  Partials      164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Visual styling issues with AILabel, revet and error states in form fields
1 participant