Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Players can sometimes join beyond the table limit #46

Open
sleepyfoxen opened this issue Jan 16, 2021 · 1 comment
Open

Players can sometimes join beyond the table limit #46

sleepyfoxen opened this issue Jan 16, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@sleepyfoxen
Copy link

Describe the bug

  • If several people sit at once, the table limit isn't enforced and players may take seats above the limit.
  • Then, the button to stand is greyed out and can't be clicked.

To Reproduce
Steps to reproduce the behavior:

  1. Create a room with a player limit
  2. Fill the table, leaving a single seat empty
  3. Have several people try to sit at the same time

Expected behavior
The table limit should be enforced -- additional players above the limit should be prevented from sitting.

Screenshots
Screenshot from 2021-01-16 04-20-07

Desktop (please complete the following information):

  • OS: Linux (Ubuntu LTS 20.04, kernel 5.4.0-62-generic)
  • Browser: Tor Browser 10.0.8 (based on Mozilla Firefox 78.6.1esr) (64-bit)

Additional context
Actions could be implemented as atomics, guaranteeing a strict total order of events.

@caracolplusplus caracolplusplus self-assigned this Jan 16, 2021
@caracolplusplus caracolplusplus added the bug Something isn't working label Jan 16, 2021
@caracolplusplus
Copy link
Owner

Ive learned that atomic arrays can be controlled on beforeSave hooks

We can clamp the length of the array there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants