Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken instanceof check with Document Fragment #1577

Closed
coffeeandwork opened this issue Nov 4, 2024 · 2 comments · Fixed by #1675
Closed

broken instanceof check with Document Fragment #1577

coffeeandwork opened this issue Nov 4, 2024 · 2 comments · Fixed by #1675
Assignees
Labels
bug Something isn't working

Comments

@coffeeandwork
Copy link

Describe the bug
If you create a document fragment object using document.createDocumentFragment() and then you check whether the returned value is an instance of DocumentFragment using happy-dom, we get a return value of false.

To Reproduce
Steps to reproduce the behavior:

  1. Create a DocumentFragment object
const myElement = document.createDocumentFragment();
  1. Run the instanceof check
console.log('is my element a DocumentFragment?:', myElement instanceof DocumentFragment);
  1. Observe that the output of above shows:
is my element a DocumentFragment?: false

The full code using happy-dom:

import { GlobalRegistrator } from '@happy-dom/global-registrator';

GlobalRegistrator.register();

const myElement = document.createDocumentFragment();
console.log('is my element a DocumentFragment?:', myElement instanceof DocumentFragment);

await GlobalRegistrator.unregister();
@coffeeandwork coffeeandwork added the bug Something isn't working label Nov 4, 2024
@capricorn86 capricorn86 self-assigned this Jan 8, 2025
capricorn86 added a commit that referenced this issue Jan 8, 2025
…not an instance of their corresponding property on Window
capricorn86 added a commit that referenced this issue Jan 8, 2025
…not an instance of their corresponding property on Window (#1675)
@capricorn86
Copy link
Owner

Thank you for reporting @coffeeandwork! 🙂

This should now be fixed in v16.5.1

@coffeeandwork
Copy link
Author

@capricorn86 thank you for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants