Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReleaseFuncs should be non-blocking #534

Open
zenhack opened this issue Jun 29, 2023 · 0 comments
Open

ReleaseFuncs should be non-blocking #534

zenhack opened this issue Jun 29, 2023 · 0 comments

Comments

@zenhack
Copy link
Contributor

zenhack commented Jun 29, 2023

I discussed this with @lthibault on matrix: It is unintuitive, awkward, and I think even undocumented that the ReleaseFuncs returned by method calls will actually block until the method call returns. Instead, I think they should never block and if a method has not already returned, arrange for the promise to be released when it does return, but don't wait for it.

The trivial implementation of this would be to just fork a goroutine in the body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant