Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build runs kj/compat/http-test which appears to reach out to the internet #14

Open
abliss opened this issue Mar 11, 2017 · 2 comments
Open

Comments

@abliss
Copy link
Contributor

abliss commented Mar 11, 2017

I was building behind a firewall, so this eventually timed out and failed, and it looks like the build succeeded anyway, but it took a long time. The IP address it was trying to reach was the one shared by capnproto.org and sandstorm.io.

@kentonv
Copy link
Member

kentonv commented Mar 12, 2017

Dang, I carefully wrote the test such that if the DNS lookup or connection failed, it would skip the test, but I didn't account for a network that succeeds at DNS lookup but then silently drops packets. I suppose I could add a timeout.

@kentonv
Copy link
Member

kentonv commented Mar 12, 2017

(All it is doing is an HTTP GET to test the HTTP client code against a real server. In theory I should, like, bundle a real HTTP server into the test in order to do this hermetically, but...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants