Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a PSI calculation that uses the _calculate_psi function in categorical columns #1028

Open
ksneab7 opened this issue Sep 18, 2023 · 0 comments
Open

Implement a PSI calculation that uses the _calculate_psi function in categorical columns #1028

ksneab7 opened this issue Sep 18, 2023 · 0 comments
Assignees
@JGSweets @taylorfturner @micdavis @ksneab7
Labels
New Feature A feature addition not currently in the library

Comments

@ksneab7
Copy link
Contributor

ksneab7 commented Sep 18, 2023

Is your feature request related to a problem? Please describe.
Categorical column PSI calculation is done outside of the rest of the code that calculates PSI because _calculate_psi requires a histogram which the categorical column class does not have currently.
PR that temporarily fixes PSI calc for categorical columns:
#1027

Describe the outcome you'd like:
I would like to see a histogram creation fix for the categorical column profiler and a rework of the PSI calculation code within the Categorical Column Profiler class to use the existing function (_calculate_psi in NumericStatsMixin)

Additional context:
@ksneab7 ksneab7 added the New Feature A feature addition not currently in the library label Sep 18, 2023
@ksneab7 ksneab7 mentioned this issue Sep 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JGSweets JGSweets

@taylorfturner taylorfturner

@micdavis micdavis

@ksneab7 ksneab7

Labels
New Feature A feature addition not currently in the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JGSweets @taylorfturner @micdavis @ksneab7