From 2f94db1941dc6c2e8fc117e2297b58be880d8075 Mon Sep 17 00:00:00 2001 From: Junho Lee <53921230+junholee6a@users.noreply.github.com> Date: Fri, 16 Jun 2023 12:35:36 -0400 Subject: [PATCH] Fix initial value of processor_type (#863) * Fix initial value of processor_type BaseDataProcessor.processor_type has type str, but is initialized in BaseDataProcessor as None, likely because it is meant to be overridden by subclasses. We initialize it as a string to remove the type error. * Change base processor_type name Co-authored-by: Taylor Turner * Make processor_type undefined in base class Also modified a test so that it can create the processor_type attribute, since it is currently not defined. Co-authored-by: JGSweets --------- Co-authored-by: Taylor Turner Co-authored-by: JGSweets --- dataprofiler/labelers/data_processing.py | 2 +- dataprofiler/tests/labelers/test_data_processing.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/dataprofiler/labelers/data_processing.py b/dataprofiler/labelers/data_processing.py index 88c5555bd..4613d05de 100644 --- a/dataprofiler/labelers/data_processing.py +++ b/dataprofiler/labelers/data_processing.py @@ -37,7 +37,7 @@ def __new__( class BaseDataProcessor(metaclass=abc.ABCMeta): """Abstract Data processing class.""" - processor_type: str = None # type: ignore[assignment] + processor_type: str # override this __subclasses: dict[str, type[BaseDataProcessor]] = {} def __init__(self, **parameters: Any) -> None: diff --git a/dataprofiler/tests/labelers/test_data_processing.py b/dataprofiler/tests/labelers/test_data_processing.py index 83bbfd85e..00b4b088b 100644 --- a/dataprofiler/tests/labelers/test_data_processing.py +++ b/dataprofiler/tests/labelers/test_data_processing.py @@ -195,6 +195,7 @@ def test_load_processor(self, mock_open, *property_mocks): with mock.patch( "dataprofiler.labelers.data_processing." "BaseDataProcessor.processor_type", new_callable=mock.PropertyMock(return_value="test"), + create=True, ): mocked_processor = BaseDataProcessor.load_from_disk("test/path")