Skip to content
This repository has been archived by the owner on Oct 3, 2019. It is now read-only.

Deploy script does not handle errors reasonably #87

Open
petiepooo opened this issue Nov 8, 2018 · 2 comments
Open

Deploy script does not handle errors reasonably #87

petiepooo opened this issue Nov 8, 2018 · 2 comments
Assignees

Comments

@petiepooo
Copy link

Connection errors (eg. because we must use a proxy) are ignored, and configuration continues as if the package was successfully downloaded. Rerunning produces many other errors due to partial configuration being present.
Scripts like the deploy script should really be idempotent.
It would also be nice to allow certain portions to be skipped, like if ntpd is allready setup, then don't deploy chrony, or if iptables is already active, don't deploy firewalld.

@peasead peasead self-assigned this Nov 8, 2018
@peasead
Copy link
Collaborator

peasead commented Nov 8, 2018

Thanks for the report, @petiepooo

I think the proxy issue is a good one, what would you suggest to fix that if the person deploying isn't using a transparent proxy?

I like the skipping idea as well. That said, generally speaking, CAPES is supposed to be deployed on a fresh build vs. a box with other services, like iptables running. However, golden images could come with those things, so point taken.

Would you be interested in submitting a PR for these issues that fit your use-case and we can see where to shim them into the project?

@petiepooo
Copy link
Author

I am actually working on some changes now. I like the way you've gathered these tools together, so I'm working on the changes that work for me.
Npm is a bear to get working via proxy, especially when it launches git behind the scenes. I think I just got that working tho as I got hackmd running now. Expect a PR in a day or two. A bunch of little commits, some of which could be skipped if desired...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants