Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use bundled barcode module instead of dowloading it #219

Closed
3 of 7 tasks
matiasfic opened this issue Jan 5, 2025 · 3 comments
Closed
3 of 7 tasks

feat: Use bundled barcode module instead of dowloading it #219

matiasfic opened this issue Jan 5, 2025 · 3 comments

Comments

@matiasfic
Copy link

Plugin(s)

  • Barcode Scanning
  • Face Detection
  • Face Mesh Detection
  • Selfie Segmentation
  • Translation

Current problem

We were using the plugin in production for a while and we are facing some scenarios in which the download of the barcode module failed (status FAILED = 5) without any reason. We checked Google Play Services is installed and updated in those scenarios and everything was ok.

Looking in the project dependencies we see the model included:
implementation "com.google.mlkit:barcode-scanning:$mlkitBarcodeScanningVersion"

So we were wondering if it is possible to avoid downloading the module on runtime and just used the already included module removing the necessity of play services dependency and resolving this dowload issues:

implementation "com.google.android.gms:play-services-code-scanner:$playServicesCodeScannerVersion"

Thanks.

Preferred solution

Remove download of barcode module from Google Play Services

Alternative options

No response

Additional context

No response

Before submitting

@robingenz
Copy link
Member

robingenz commented Jan 5, 2025

These are two different SDKs. com.google.mlkit:barcode-scanning is used by the startScan(...) method and is bundled. com.google.android.gms:play-services-code-scanner is used by the scan(...) method and cannot be bundled as far as I know. I'm therefore closing this issue. I recommend using the startScan(...) method in your case.

@robingenz robingenz closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2025
@matiasfic
Copy link
Author

So just to clarify, can I use startScan without installing barcode module? I am actually using startScan, not scan method.

@robingenz
Copy link
Member

So just to clarify, can I use startScan without installing barcode module? I am actually using startScan, not scan method.

Yes, without the com.google.android.gms:play-services-code-scanner dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants