We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug
A byte array is encoded to a hex strings in two different ways, depending on the direction of flow.
Generally
AE B1 11
AEB111
This inconsistency was introduced in performance optimisations added as part of #701 and was noticed in #717 (comment)
There is no defective behaviour here. However, the inconsistency is likely to be confusing for developers and people debugging.
To Reproduce The inconsistency can be seen in the JavaScript side by comparing the hex string conversion functions
Native => JS
toHexString
hexStringToDataView
JS => native
dataViewToHexString
stringToBytes
Expected behavior A consistent hex-encoding format should be used throughout.
Plugin version:
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Describe the bug
A byte array is encoded to a hex strings in two different ways, depending on the direction of flow.
Generally
AE B1 11
)AEB111
)This inconsistency was introduced in performance optimisations added as part of #701 and was noticed in #717 (comment)
There is no defective behaviour here. However, the inconsistency is likely to be confusing for developers and people debugging.
To Reproduce
The inconsistency can be seen in the JavaScript side by comparing the hex string conversion functions
Native => JS
toHexString
- contains no spaces - android and iOShexStringToDataView
- expects no spaces - JSJS => native
dataViewToHexString
- contains spaces - JSstringToBytes
- expects spaces - android and iOSExpected behavior
A consistent hex-encoding format should be used throughout.
Plugin version:
The text was updated successfully, but these errors were encountered: