Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a visual indication that a table column is sortable #5365

Open
apollo13 opened this issue Oct 2, 2024 · 4 comments
Open

Provide a visual indication that a table column is sortable #5365

apollo13 opened this issue Oct 2, 2024 · 4 comments
Labels
Vanilla WG Task owned by Vanilla Working Group WG: Proposal Working group proposals

Comments

@apollo13
Copy link

apollo13 commented Oct 2, 2024

I searched all existing issues and am pretty sure this issue does not exist yet -- sorry if I missed something.

There is currently no visual indication whether a column is sortable or not without hovering it. Iconwise I could imagine using something like p-icon--sort-both but adjusted to p-icon--chevron-*.

As an example this is how it looks in patternfly:
image

As you can see there we are currently sorting the repository column and "branches"/"pull requests" are sortable.

@apollo13 apollo13 added the WG: Proposal Working group proposals label Oct 2, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-15552.

This message was autogenerated

@bartaz bartaz added the Vanilla WG Task owned by Vanilla Working Group label Oct 3, 2024
@danielmutis
Copy link

Thanks for submitting this issue @apollo13

From our working group: we agree with the need for an indicator for sortable columns in our table. We propose to solve this issue in a similar way to how Gov.uk does it.

To be considered:

  • We will be doing this change at a later date since it's not an urgent problem. We are currently working on a new architecture for Vanilla, and this work will be done once that is completed.
  • When the column name has an icon, e.g. an information icon with a tooltip, the arrows would be closer to the label than the info icon. This follows our spacing rules detailed here.

@apollo13
Copy link
Author

apollo13 commented Oct 16, 2024 via email

@bartaz
Copy link
Member

bartaz commented Oct 16, 2024

@apollo13 We are currently in the process of specifying, prototyping, and discussing the approach to design system (both in terms of design system fundamentals, and technicalities of the future technical architecture of the implementation). So it's a bit too early to share details. We plan for React to be a first class citizen and first supported platform, but we want to be open and flexible, and possibly support other web implementations leter, so having a shared (S)CSS core is definitely something we consider.

But it's too early to know what exact shape and scope it will have.

For now, current Vanilla codebase is not going anywhere. We are planning to maintain it and keep stable as long as it will be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Vanilla WG Task owned by Vanilla Working Group WG: Proposal Working group proposals
Projects
None yet
Development

No branches or pull requests

3 participants