Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provider seems to have redundant logic, cloned from the requirer #422

Open
dstathis opened this issue Nov 13, 2024 · 0 comments
Open

Provider seems to have redundant logic, cloned from the requirer #422

dstathis opened this issue Nov 13, 2024 · 0 comments
Labels
Status: Triage Type: Enhancement

Comments

@dstathis
Copy link
Contributor

dstathis commented Nov 13, 2024 •
edited
Loading

Original issue in traefik-route repo

  • _stored gets overwritten every loop iteration.
  • Why the provider needs to extract this from relation data? Seems like this was cloned from the requirer. Not sure.

https://github.com/canonical/traefik-route-k8s-operator/blob/d25e1487079935182de9444061646218e9c9df61/lib/charms/traefik_route_k8s/v0/traefik_route.py#L206-L214

Originally posted in #234 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Triage Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dstathis