Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charm_tracing] Add juju_charm to topology attributes #64

Open
mmkay opened this issue Nov 11, 2024 · 1 comment
Open

[charm_tracing] Add juju_charm to topology attributes #64

mmkay opened this issue Nov 11, 2024 · 1 comment

Comments

@mmkay
Copy link
Contributor

mmkay commented Nov 11, 2024

Enhancement Proposal

In charm_tracing, we create resource attributes for the root span:

        resource = Resource.create(
            attributes={
(...)
                # juju topology
                "juju_unit": unit_name,
                "juju_application": self.app.name,
                "juju_model": self.model.name,
                "juju_model_uuid": self.model.uuid,
            }
        )

They don't contain the charm name itself. Should it be added?

@PietroPasotti
Copy link
Contributor

I can't recall why I didn't add it. I think it didn't sound especially useful given we already have charm type and unit.
We could do that though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants