Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing for custom vale config #331

Closed
rkratky opened this issue Jan 30, 2025 · 1 comment
Closed

Allowing for custom vale config #331

rkratky opened this issue Jan 30, 2025 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@rkratky
Copy link
Contributor

rkratky commented Jan 30, 2025

Currently, we check for the existence of vale.ini and only run get_vale_conf.py if it isn't found. That means it's cumbersome to have a custom vale.ini in the repo: one needs to modify both the Makefile (remove the check for vale.ini) and the script that fetches the vale config (add a check for vale.ini, so it's not overwritten).

I propose to default to a behavior that would run get_vale_conf.py regardless of vale.ini presence and only fetch vale.ini if it doesn't exist already.

(Use case: custom vale severity settings (warning vs error).)

@rkratky rkratky added enhancement New feature or request question Further information is requested labels Jan 30, 2025
@SecondSkoll
Copy link
Collaborator

Change made in #333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants