Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon is not handle properly when base is core22 #4402

Open
tsunghanliu opened this issue Oct 13, 2023 · 0 comments
Open

icon is not handle properly when base is core22 #4402

tsunghanliu opened this issue Oct 13, 2023 · 0 comments
Labels
bug Actual bad behavior that don't fall into maintenance or documentation

Comments

@tsunghanliu
Copy link

Bug Description

The icon is not properly placed in prime/meta/gui when base is core22.

To Reproduce

  1. use the attached snapcraft.yaml and change base to core20 or core22
  2. build the snap (destructive-mode should work)
  3. check if icon.png is in prime/meta/gui

Environment

Ubuntu 22.04
snapcraft 7.5.3

snapcraft.yaml

name: test-icon
base: core20
version: '0.1'
summary: test-icon
description: |
  test icon handle of snapcraft
grade: devel
confinement: devmode
icon: icon.png

parts:
  icon:
    plugin: nil
    override-build: |
      cat << EOF | base64 -d >> $SNAPCRAFT_PROJECT_DIR/icon.png
      iVBORw0KGgoAAAANSUhEUgAAAQAAAAEACAYAAABccqhmAAAACXBIWXMAAA7EAAAOxAGVKw4bAAAD
      HUlEQVR4nO3UMQEAIAzAMMC/5yFjRxMFvXpnZg6Q9LYDgD0GAGEGAGEGAGEGAGEGAGEGAGEGAGEG
      AGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEG
      AGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEG
      AGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEG
      AGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEG
      AGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEG
      AGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEG
      AGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEG
      AGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEG
      AGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEG
      AGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEG
      AGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEG
      AGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEG
      AGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEGAGEf
      HrAF/LZ/lzEAAAAASUVORK5CYII=
      EOF

Relevant log output

## base: core 22
$ snapcraft --destructive-mode
Executed: pull icon                                                                                                                                                                                        
Executed: build icon                                                                                                                                                                                       
Executed: stage icon                                                                                                                                                                                       
Executed: prime icon                                                                                                                                                                                       
Executed parts lifecycle                                                                                                                                                                                   
Generated snap metadata                                                                                                                                                                                    
Created snap package test-icon_0.1_amd64.snap                                                           
$ tree prime/
prime/
└── meta
    ├── gui
    └── snap.yaml

2 directories, 1 file

## base: core20
$ snapcraft --destructive-mode
Pulling icon 
+ snapcraftctl pull
Building icon 
+ cat
+ base64 -d
Staging icon 
+ snapcraftctl stage
Priming icon 
+ snapcraftctl prime
Snapping |                                                                                                                                                                                       
Snapped test-icon_0.1_amd64.snap
$ tree prime
prime
└── meta
    ├── gui
    │   └── icon.png
    └── snap.yaml

2 directories, 2 files

Additional context

No response

@tsunghanliu tsunghanliu added the bug Actual bad behavior that don't fall into maintenance or documentation label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Actual bad behavior that don't fall into maintenance or documentation
Projects
None yet
Development

No branches or pull requests

1 participant