Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote-build: new command logic #4324

Closed
4 tasks
mr-cal opened this issue Aug 14, 2023 · 0 comments · Fixed by #4395
Closed
4 tasks

remote-build: new command logic #4324

mr-cal opened this issue Aug 14, 2023 · 0 comments · Fixed by #4395
Labels
enhancement New features or optimizations

Comments

@mr-cal
Copy link
Collaborator

mr-cal commented Aug 14, 2023

What needs to get done

  • Implement the new work area, where the WorkTree is not reused and removed after the build completes.
    • Each launchpad build has a unique build-id and WorkTree. In the legacy code, WorkTrees are stored by build-id in ~/.local/share/snapcraft/remote-build/<build-id>/.
    • In the new code, WorkTrees will be stored in the work area ~/.cache/snapcraft/remote-build/<build-id>/. When the build completes successfully, the WorkTree will be removed. WorkTrees are not reused.
  • use new _generate_build_id() from remote-build: migrate build-id generation #4322
  • linting and typing updates (e.g. use f-strings)
  • move snapcraft business logic to snapcraft/commands/remote.py

Why it needs to get done

This allows a user to inspect the contents of the WorkTree if the build fails and minimizes disk usage.

@mr-cal mr-cal added the enhancement New features or optimizations label Aug 14, 2023
@sergiusens sergiusens changed the title remote-build: refactor work area remote-build: new command logic Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or optimizations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant