Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert test_seldon_servers.py based on response status and structure #239

Open
orfeas-k opened this issue Feb 8, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@orfeas-k
Copy link
Contributor

orfeas-k commented Feb 8, 2024

Context

The tests assert the exact results returned from a SeldonDeployment. However, neither our charm neither using ROCKs instead of upstream images should be able to break the seldonDeployments results, as long as they actually return a successful response. Thus, tests should assert that the response is a successful one and that they actually contain results.

What needs to get done

Modify tests assertion

Definition of Done

Tests assert based on response status and structure instead of specific results.

@orfeas-k orfeas-k added the enhancement New feature or request label Feb 8, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5309.

This message was autogenerated

@orfeas-k orfeas-k changed the title Modify assertion in test_seldon_servers.py Assert test_seldon_servers.py based on response status and structure Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Labeled
Development

No branches or pull requests

1 participant