-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable poetry workflow #236
base: main
Are you sure you want to change the base?
Conversation
This is blocked until I make it work with the following PR: canonical/synapse-operator#223 |
@@ -216,51 +216,6 @@ jobs: | |||
STDOUT_LOG=$(mktemp --suffix=stdout.log) | |||
echo STDOUT_LOG=$STDOUT_LOG >> $GITHUB_ENV | |||
tox --result-json=test-result.json | tee $STDOUT_LOG ; test ${PIPESTATUS[0]} -eq 0 | |||
- name: Check lint and test stdout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for removing this please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When using poetry, the dependencies will be handled in the pyproject.toml
file and this test will always fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it somehow be adapted so that we still get the benefits please? It is checking here that the expected tools are being run which is quite helpful to make sure that the expected linting is actually being done in a given repo
This is now marked ready for review, but I think the PR description is out of sync (e.g. |
Good point, perhaps @nrobinaubertin would you like to take over this PR please? |
I'll take it over. |
…r-workflows into dependency-version-pin
@nrobinaubertin @jdkandersson is this being worked on? I suggest closing it if not and we can reopen it if needed.. |
Applicable spec: ISD115
Overview
tox -e pack
command instead ofcharmcraft pack
to enable the use of poetrytox.ini
's dependencies check since they will be located inpyproject.toml
Rationale
Enable workflows with full dependency pinning using poetry.
PRs using this branch:
Workflow Changes
The integration test has been changed to optionally use
tox -e pack
command instead ofcharmcraft pack
Checklist
urgent
,trivial
,complex
)