Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "OIDC_AUTH_URL" env variable from service configuration #158

Open
DnPlas opened this issue Jul 5, 2024 · 1 comment
Open

Remove "OIDC_AUTH_URL" env variable from service configuration #158

DnPlas opened this issue Jul 5, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@DnPlas
Copy link
Contributor

DnPlas commented Jul 5, 2024

Context

The OIDC_AUTH_URL is used to initiate the Authorization Code Flow. This client is actually capable of discovering this value by hitting the OIDC provider's (e.g. Dex) .well-known endpoint, so as long as the OIDC provider is exposing this information, it should be enough.

Right now, this value is hard coded to /dex/auth, and while it is not incorrect, it is preferred that the OIDC provider (in this case dex-auth) sets it, in the end this is the charm that will know this information. oidc-gatekeeper on its side can just infer it in order to keep these values accurate and equal in both charms.

This task depends on canonical/dex-auth-operator#202

What needs to get done

Remove the OIDC_AUTH_URL env variable and allow the client to infer it form dex-auth's .well-known endpoint.

Definition of Done

The oidc-gatekeeper does not depend on the variable for initiating the Authorization flow.

@DnPlas DnPlas added the enhancement New feature or request label Jul 5, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5970.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant