From 0318021e9c4841518d638789f865d3f255cda717 Mon Sep 17 00:00:00 2001 From: shayancanonical <99665202+shayancanonical@users.noreply.github.com> Date: Tue, 30 Apr 2024 09:32:32 -0400 Subject: [PATCH] Fix missing kwargs in some methods (#236) ## Issue There are some inconsistencies with shared files with mysql-router vm (see [PR 143](https://github.com/canonical/mysql-router-operator/pull/143) ## Solution Fix inconsistencies --- src/kubernetes_upgrade.py | 2 +- src/upgrade.py | 2 +- src/workload.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/kubernetes_upgrade.py b/src/kubernetes_upgrade.py index 9d1d6a03e..b9964453a 100644 --- a/src/kubernetes_upgrade.py +++ b/src/kubernetes_upgrade.py @@ -241,7 +241,7 @@ def determine_partition() -> int: def authorized(self) -> bool: raise Exception("Not supported on Kubernetes") - def upgrade_unit(self, *, workload_: workload.Workload, tls: bool) -> None: + def upgrade_unit(self, *, event, workload_: workload.Workload, tls: bool) -> None: raise Exception("Not supported on Kubernetes") diff --git a/src/upgrade.py b/src/upgrade.py index d1546b95d..0535c89f2 100644 --- a/src/upgrade.py +++ b/src/upgrade.py @@ -223,7 +223,7 @@ def authorized(self) -> bool: """ @abc.abstractmethod - def upgrade_unit(self, *, workload_: workload.Workload, tls: bool) -> None: + def upgrade_unit(self, *, event, workload_: workload.Workload, tls: bool) -> None: """Upgrade this unit. Only applies to machine charm diff --git a/src/workload.py b/src/workload.py index bcad03dba..de4b3c2f2 100644 --- a/src/workload.py +++ b/src/workload.py @@ -430,7 +430,7 @@ def upgrade( if enabled: logger.debug("Disabling MySQL Router service before upgrade") self._disable_router() - super().upgrade(unit=unit, tls=tls, exporter_config=exporter_config) + super().upgrade(event=event, unit=unit, tls=tls, exporter_config=exporter_config) if enabled: logger.debug("Re-enabling MySQL Router service after upgrade") self._enable_router(event=event, tls=tls, unit_name=unit.name)