All problems in computer science can be solved by another level of indirection #3613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't help. :( https://github.com/canonical/mir/actions/runs/11035413503/job/30651347065?pr=3613 ...and https://github.com/canonical/mir/actions/runs/11035413503/job/30651343458?pr=3613 (Not a big sample, but did this actually make things WORSE?) |
AlanGriffiths
force-pushed
the
using-ci-for-experiments
branch
from
8af5d1b
to
a4fabf3
Compare
AlanGriffiths
changed the title
|
A clean run twice! "That alone should encourage the crew..." |
|
'fraid not: https://github.com/canonical/mir/actions/runs/11037356604/job/30683939003?pr=3613 |
Still noBut this bit is interesting: The previous server seems to be hanging about still? So you'd be right that it could be a shutdown (or a parallel test?) issue |
That shouldn't be an issue. That message happens whenever libwayland-server is searching for a socket to offer |
AlanGriffiths
force-pushed
the
using-ci-for-experiments
branch
from
ad51d32
to
ab024f2
Compare
AlanGriffiths
force-pushed
the
using-ci-for-experiments
branch
from
4978922
to
3367f71
Compare
|
The tests that have failed:
So both |
|
[Sigh!] I was beginning to hope I'd guessed a solution. But... fe1c4b8 failed once in four spread runs:
|
|
Just seen this: I wonder if there's a segfault lurking in the testing stack that this test just happens to trigger |
AlanGriffiths
changed the title
|
5400e0d passed 5 repeats of the spread action without seeing this problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
miral::ConfigFile"Watcher" can be destroyed before the main loop invokes the handler it supports. So add another level of indirection to check it is still there.Plus some hygienic improvements to the test fixture.
Fixes: #3612