Do not stop Kubernetes services on node removal if annotation is set. #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Amazing work catching this super subtle issue! Thanks @bschimke95! left some minor comments.
HomayoonAlimohammadi
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Wonderful job, thanks a lot @bschimke95! LGTM overall, but left some minor comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires canonical/k8s-snap-api#8 - will update api version tag for the snap afterwards.
By default, all services on a leaving node are stopped. This PR adds logic to skip this step if the
k8sd/v1alpha/lifecycle/skip-stop-services-on-removeannotation is set.This is required for Cluster API to properly drain nodes. See
Also adds an integration test to validate that this works as expected.