Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IAM 968 #382

Merged
merged 3 commits into from
Aug 27, 2024
Merged

IAM 968 #382

merged 3 commits into from
Aug 27, 2024

Conversation

shipperizer
Copy link
Contributor

@shipperizer shipperizer commented Aug 20, 2024 •
edited
Loading

IAM-968: REBAC Identities service implementation

  • fix: update tracing signature
  • fix: create openfga store to enhance basic client and offload core application logic
  • feat: identities service implementation

@shipperizer shipperizer requested a review from a team as a code owner August 20, 2024 15:05
@shipperizer shipperizer force-pushed the IAM-968 branch 4 times, most recently from 04d7d4c to e7d5d47 Compare August 21, 2024 15:04
@shipperizer shipperizer dismissed wood-push-melon’s stale review August 22, 2024 20:56

The merge-base changed after approval.

BarcoMasile
BarcoMasile previously approved these changes Aug 27, 2024
View reviewed changes
internal/openfga/stores.go Outdated Show resolved Hide resolved
@shipperizer shipperizer dismissed BarcoMasile’s stale review August 27, 2024 08:11

The merge-base changed after approval.

nsklikas
nsklikas approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@nsklikas nsklikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall, just one minor suggestion. Feel free to merge without changing it

internal/openfga/stores.go Show resolved Hide resolved
@shipperizer shipperizer merged commit eb5c602 into main Aug 27, 2024
10 checks passed
@shipperizer shipperizer deleted the IAM-968 branch August 27, 2024 11:25
shipperizer added a commit that referenced this pull request Aug 29, 2024
@shipperizer
Merge pull request #382 from canonical/IAM-968
6570281 
IAM 968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsklikas nsklikas nsklikas approved these changes

@BarcoMasile BarcoMasile BarcoMasile approved these changes

@wood-push-melon wood-push-melon wood-push-melon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shipperizer @BarcoMasile @nsklikas @wood-push-melon