Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate specs struct with go-playground/validator library to validate external configuration #328

Open
BarcoMasile opened this issue Jun 17, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@BarcoMasile
Copy link
Contributor

BarcoMasile commented Jun 17, 2024

Description

Right now external configuration in Admin UI is not validated. we need to make sure it's ok validating it right away using the validator library we already use in the project.

This is needed to avoid weird errors at runtime or during the setup of the backend server.

This should be done in the serve.go file.
We should validate the EnvSpecs object, right after applying the needed validation tags in specs.go.

The whole process of "preparing" the specs object could be (strongly advised) grouped in a single function that is invoked inside the serve() method.

@BarcoMasile BarcoMasile added the enhancement New feature or request label Jun 17, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/IAM-925.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant