Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework PackageService API #420

Open
lengau opened this issue Aug 14, 2024 · 0 comments
Open

Rework PackageService API #420

lengau opened this issue Aug 14, 2024 · 0 comments
Labels
Enhancement New feature or request
Milestone
5.0

Comments

@lengau
Copy link
Contributor

lengau commented Aug 14, 2024 •
edited
Loading

What needs to get done

  • Remove prime_dir from pack
  • Remove metadata altogether
  • Make write_metadata abstract with no path parameter
  • Explain that write_metadata should write all metadata files into the prime directory.

Why it needs to get done

The current API no longer makes sense for all craft apps.
@lengau lengau added the Enhancement New feature or request label Aug 14, 2024
@lengau lengau added this to the 5.0 milestone Aug 14, 2024
@lengau lengau mentioned this issue Aug 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
1 participant
@lengau