Adapt scale test to not remove HA #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschimke95
force-pushed
the
KU-1520/slow-node-removal
branch
from
20c20e2
to
d52cbae
Compare
bschimke95
force-pushed
the
KU-1520/slow-node-removal
branch
from
4613528
to
8e8a1f5
Compare
bschimke95
force-pushed
the
KU-1520/slow-node-removal
branch
from
106a886
to
f900b2e
Compare
HomayoonAlimohammadi
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a race condition that pops up if a workload cluster is scaled down. As part of the CK8s node removal, all services are stopped on the leaving node. This includes
kubeletwhich causes the node to be reported as "not available" before the core CAPI controllers attempt to drain the node.By setting the annotation, we ensure that CAPI takes full control of the nodes removal process.
Note that we could also change the existing
skip-node-on-removalannotation but there might be another use-case for just stopping services (+backward-compatibility).Requires:
canonical/k8s-snap#682
canonical/k8s-snap-api#8