Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DPE-2221 DPE-2224 Rename version and dump only rock license into the image #32

Merged
merged 1 commit into from
Aug 11, 2023
Merged

DPE-2221 DPE-2224 Rename version and dump only rock license into the image #32

merged 1 commit into from
Aug 11, 2023

Conversation

shayancanonical
Copy link
Contributor

Issue

  • We are versioning like 8.0.33-0
  • We are statically dumping all the licenses into the git repo
  • We have a number of updates in the snap and so we would like to rebuild the rock to get these updates

Solution

  • We should instead just version as 8.0.33
  • We should be extracting licenses from installed packages - this is already done in the snap

@shayancanonical shayancanonical merged commit 1f876fb into 8.0-22.04 Aug 11, 2023
10 checks passed
@shayancanonical shayancanonical deleted the fix/version branch August 11, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulomach paulomach paulomach approved these changes

@taurus-forever taurus-forever taurus-forever approved these changes

@carlcsaposs-canonical carlcsaposs-canonical carlcsaposs-canonical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shayancanonical @paulomach @taurus-forever @carlcsaposs-canonical