Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In image scan workflow naming of report files is missing release and risk #695

Closed
i-chvets opened this issue Sep 11, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@i-chvets
Copy link
Contributor

i-chvets commented Sep 11, 2023

Bug Description

After the update to the workflow done in #686 variables that are used to generate filenames have been changed. This causesd unset variables to be used when generating report file names.

For example this path: trivy-reports-2023-09-11-01-49-07---1.tar.gz from here should have been path: trivy-reports-2023-09-11-01-49-07-1.7-stable-1.tar.gz

The following lines need to be addressed and proper file name should be generated:
https://github.com/canonical/bundle-kubeflow/blob/main/.github/workflows/scan-images.yaml#L59
https://github.com/canonical/bundle-kubeflow/blob/main/.github/workflows/scan-images.yaml#L62
https://github.com/canonical/bundle-kubeflow/blob/main/.github/workflows/scan-images.yaml#L67
https://github.com/canonical/bundle-kubeflow/blob/main/.github/workflows/scan-images.yaml#L72

To Reproduce

Refer to image scan workflow execution, eg. https://github.com/canonical/bundle-kubeflow/actions/runs/6140822553

Environment

Image scan workflow in Github Runner.

Relevant Log Output

Run tar zcvf trivy-reports-2023-09-11-01-49-07---1.tar.gz ./trivy-reports
  tar zcvf trivy-reports-2023-09-11-01-49-07---1.tar.gz ./trivy-reports

Additional Context

N/A

@i-chvets i-chvets added the bug Something isn't working label Sep 11, 2023
i-chvets pushed a commit that referenced this issue Sep 12, 2023
#695

Summary of changes:
- Modified workflow to parse release-risk according to new setup and use
  output varible in creating report names.
i-chvets added a commit that referenced this issue Sep 15, 2023
fix: modified workflow to parse release-risk
#695

Summary of changes:
- Modified workflow to parse release-risk according to new setup and use
  output varible in creating report names.
@kimwnasptd
Copy link
Contributor

Closing since we merged #697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants