-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add progress bars for ETL #319
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm converting this to draft. My brain on this issue has gone like this
We should handle the GFF reader issue and return to this afterwards |
This PR is stale because it has been open 7 day(s) with no activity. Please review this PR. |
@jsstevenson do you intend to come back to this at some point? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we have
tqdm
as an issue here, but this does it.In doing so, refactors GFF processing to use
gffpandas
instead ofgffutils
(in order to be able to get atotal
number fortqdm
). As a happy side effect, this significantly cuts down Ensembl and (I think) NCBI loading time (using Pandas, unfortunately -- with a little effort we could probably spin up something better, maybe next Tech the Halls). It did entail a fair amount of internal refactoring for those sources.