Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI refactor #293

Closed
jsstevenson opened this issue Nov 14, 2023 · 1 comment
Closed

CLI refactor #293

jsstevenson opened this issue Nov 14, 2023 · 1 comment
Labels
enhancement New feature or request priority:low Low priority

Comments

@jsstevenson
Copy link
Member

jsstevenson commented Nov 14, 2023

I think the CLI module should basically house the bare minimum level of "standalone app" functionality. There's some stuff in there that might be reusable by another application (for example, we actually import parts of the disease CLI in therapy because it's an easy way to run the updating routines). Maybe we could move some of that up to the etl module or something.

Since the CLI is supposed to be a "standalone app", this could also give us some leeway to set more humane logging parameters there. Currently, DynamoDB produces around 15 lines of logs every second. This might be slowing us down, and also makes actually using the logs kind of difficult since 99.9% of the time the problem is not with some arcane botocore connection (and if it was, I'd never be able to figure it out anyway...). It'd be bad form to change the botocore/boto3 logging levels in importable parts of the normalizer, but we could probably do it within the CLI (maybe enable verbose logging with a CLI option?).

@jsstevenson jsstevenson added enhancement New feature or request priority:medium Medium priority priority:low Low priority and removed priority:medium Medium priority labels Nov 14, 2023
@jsstevenson
Copy link
Member Author

closed in #299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low Low priority
Projects
None yet
Development

No branches or pull requests

1 participant