Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database endpoint usage feedback #217

Closed
jsstevenson opened this issue Jul 5, 2023 · 4 comments
Closed

Database endpoint usage feedback #217

jsstevenson opened this issue Jul 5, 2023 · 4 comments
Labels

Comments

@jsstevenson
Copy link
Member

jsstevenson commented Jul 5, 2023

It's probably nonstandard behavior to always print feedback to the console about the currently-used database endpoint when the connection is created. I tentatively think we should be making a logging call instead. We could also make an optional verbose mode or something, too, but that would be more work.

@jsstevenson jsstevenson added the priority:low Low priority label Jul 5, 2023
@korikuzma
Copy link
Member

Personally, I like this when connected to AWS instance (by accident). So then I can immediately stop when I see that it's not using local when it should be

@jsstevenson
Copy link
Member Author

Yeah, I think retaining a notification is helpful in some cases (maybe some commands more than others) but I think there are good reasons to provide verbosity/quiet options, maybe with silence as a default -- see eg http://www.linfo.org/rule_of_silence.html (I think the bit about leaving output minimal by default unless it's something that might need to be piped is good).

Copy link

This issue is stale because it has been open 180 days with no activity. This issue will be closed if no further activity occurs in 14 days.

@github-actions github-actions bot added the stale label Jul 17, 2024
@jsstevenson
Copy link
Member Author

Strictly speaking, this is done as of #299 but I don't believe that branch is merged to main yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants