Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring user's attention to element affected by undo/redo #4784

Open
jarekdanielak opened this issue Jan 9, 2025 · 4 comments
Open

Bring user's attention to element affected by undo/redo #4784

jarekdanielak opened this issue Jan 9, 2025 · 4 comments
Labels
backlog Queued in backlog BPMN enhancement New feature or request spring cleaning Could be cleaned up one day ux

Comments

@jarekdanielak
Copy link
Contributor

jarekdanielak commented Jan 9, 2025

Problem you would like to solve

Currently there is no visual indication of undo/redo changing an element. This means that when mass-undoing/redoing, you can miss a change made in some part of the diagram you weren't paying attention to.

In the below example, I:

  • add an execution listener,
  • go to some other task to edit properties,
  • decide to undo them,
  • hit undo one too many and remove an execution listener.
Screen.Recording.2025-01-09.at.17.39.33.mov

Proposed solution

After a discussion with @lmbateman, here are some ideas to make sure changes made by undo/redo don't go unnoticed:

  • auto-select element(s) modified by undo/redo,
  • (optional) open properties panel if change is visible there
  • (optional) open affected properties panel group (e.g. expand Execution listeners section if undo removed one)

Alternatives considered

Leave it as it is if it's not a concern for users.

Additional context

Would fix #4772

@jarekdanielak jarekdanielak added BPMN needs discussion Needs further discussion enhancement New feature or request labels Jan 9, 2025
@jarekdanielak jarekdanielak changed the title Bring user's attention to element effected by undo/redo Bring user's attention to element affected by undo/redo Jan 9, 2025
@barmac barmac added the ux label Jan 10, 2025
@barmac
Copy link
Collaborator

barmac commented Jan 10, 2025

I think this is a valid request, though I'd rather not prioritize it as I've never seen any users complaining about it.

@nikku
Copy link
Member

nikku commented Jan 10, 2025

@jarekdanielak As we have elements.changed as a general feature available you could fairly easily try this, today. I'd add the spring cleaning tag, and/or consider to slack on this, one day and see how it feels.

@jarekdanielak
Copy link
Contributor Author

Thanks for the inputs. I'm adding it to backlog as a spring cleaning item, hope to slack on this soon.

@jarekdanielak jarekdanielak added backlog Queued in backlog spring cleaning Could be cleaned up one day and removed needs discussion Needs further discussion labels Jan 10, 2025
@nikku
Copy link
Member

nikku commented Jan 10, 2025

Given that undo and redo are even more context sensitive than before I'd expect some sort of visual feedback for it happening. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog BPMN enhancement New feature or request spring cleaning Could be cleaned up one day ux
Projects
None yet
Development

No branches or pull requests

3 participants