Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.22 add tomcat 10 documentation #1647

Merged
merged 18 commits into from
Jul 4, 2024
Merged

Conversation

psavidis
Copy link
Contributor

@psavidis psavidis commented Jun 13, 2024

psavidis and others added 6 commits June 13, 2024 17:01
Tomcat Manual Installation Section
Tomcat Manual Installation Section
The above sections need to include both camunda-webapp-tomcat and camunda-webapp-tomcat-jakarta artifacts

Tomcat Manual Installation Section
Add missing section "Migrate Java webapp plugins"
@psavidis psavidis marked this pull request as ready for review June 24, 2024 21:00
psavidis and others added 4 commits June 28, 2024 15:26
# Conflicts:
#	content/update/minor/721-to-722/_index.md
This change is to emphasize:

- the benefits of tomcat 10
- to stress that this version will be based on tomcat 10 (distro,docker)

code-review point
Copy link
Member

@danielkelemen danielkelemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good! Added two more notes.

content/update/minor/721-to-722/_index.md Outdated Show resolved Hide resolved
content/update/minor/721-to-722/_index.md Outdated Show resolved Hide resolved
@psavidis
Copy link
Contributor Author

psavidis commented Jul 1, 2024

Update

Review is complete. Will proceed to merge this documentation PR after the main code PR is merged.

@psavidis
Copy link
Contributor Author

psavidis commented Jul 1, 2024

@danielkelemen I've added the Patch level update section addition in the docs for informing users of Tomcat 10 module support for the 7.21 Backport.

Once the above is finalised after the review, i can proceed to add the above section also to the 7.21 branch

Add the reference to the patch level update section
Copy link
Member

@tasso94 tasso94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. But I have some review hints:

content/update/minor/721-to-722/_index.md Outdated Show resolved Hide resolved
content/update/minor/721-to-722/_index.md Show resolved Hide resolved
content/update/minor/721-to-722/_index.md Outdated Show resolved Hide resolved
@psavidis psavidis requested a review from tasso94 July 3, 2024 13:04
@psavidis psavidis merged commit 68bf0df into master Jul 4, 2024
1 check passed
@psavidis psavidis deleted the 7.22-add-tomcat-10-documentation branch July 4, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants