Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rest): expose batch id for job and historic job log to REST API #4640

Merged
merged 1 commit into from
Sep 20, 2024
Merged

chore(rest): expose batch id for job and historic job log to REST API #4640

merged 1 commit into from
Sep 20, 2024

Conversation

mboskamp
Copy link
Member

Related to #4206

@mboskamp mboskamp added the ci:rest-api Runs extra builds for the REST API (currently only WLS compatibility builds). label Sep 20, 2024
@mboskamp mboskamp self-assigned this Sep 20, 2024
@mboskamp mboskamp marked this pull request as ready for review September 20, 2024 09:54
@mboskamp mboskamp mentioned this pull request Sep 20, 2024
Closed
9 tasks
danielkelemen
danielkelemen approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@danielkelemen danielkelemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

@danielkelemen
Copy link
Member

Optional: If we want to sort by batch id, add sort option: org.camunda.bpm.engine.rest.dto.history.HistoricJobLogQueryDto

I guess we are not doing this.

@mboskamp
Copy link
Member Author

Optional: If we want to sort by batch id, add sort option: org.camunda.bpm.engine.rest.dto.history.HistoricJobLogQueryDto

I guess we are not doing this.

I would say, let's not do it right now and create a follow-up ticket that we can tackle if it becomes a requirement. Testing the sorting will be more effort which would be nice to avoid now, close to the release. Do you disagree?

@mboskamp
Copy link
Member Author

Created #4644 as follow-up for adding sorting options.

@mboskamp mboskamp merged commit 402bed9 into 4206-batchid-job-joblog Sep 20, 2024
4 checks passed
@mboskamp mboskamp deleted the 4206-batchid-job-joblog-rest branch September 20, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkelemen danielkelemen danielkelemen approved these changes

Assignees

@mboskamp mboskamp

Labels
ci:rest-api Runs extra builds for the REST API (currently only WLS compatibility builds).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mboskamp @danielkelemen