Fix camunda-spin-bom import in camunda-only-bom #4605 #4628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@cachescrubber
On first glance, changes look good. So please apply the same for commons, connect, that will be great.
I triggered our CI with the changes and I see the following error, could you please check what might be wrong?
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.7:deploy (default-deploy) on project camunda-spin-bom: Deployment failed: repository element was not specified in the POM inside distributionManagement element or in -DaltDeploymentRepository=id::layout::url parameter
Command that is executed in root:
mvn clean source:jar deploy source:test-jar -Pdistro,distro-ce,distro-wildfly,distro-webjar,h2-in-memory`
|
Hi @yanavasileva - I assigned |
yanavasileva
approved these changes
Sep 19, 2024
|
please review camunda-commons-bom. I think I'll get connect-box done at until tomorrow. |
|
Testing was successful. I will merge the changes later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix camunda-spin-bom import in camunda-only-bom #4605
Fixes #4605
It was necessary to remove the parent from
camunda-spin-bom, because it would introduce a cyclic import of thecamunda-bomwhich would in turn importcamunda-spin-bom....camunda-spin-bomcurrently is without parent. Should it be necessary I would suggest to usecamunda-bpm-release-parent.