Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(engine): add batchId for job and jobLog #4625

Merged
merged 17 commits into from
Sep 20, 2024
Merged

chore(engine): add batchId for job and jobLog #4625

merged 17 commits into from
Sep 20, 2024

Conversation

mboskamp
Copy link
Member

Related to #4206

@mboskamp mboskamp added the ci:h2 Runs the builds for the H2 database. label Sep 17, 2024
@mboskamp mboskamp self-assigned this Sep 17, 2024
@mboskamp mboskamp mentioned this pull request Sep 17, 2024
Closed
9 tasks
@mboskamp mboskamp added ci:all-db Runs the builds for all databases. and removed ci:h2 Runs the builds for the H2 database. labels Sep 17, 2024
@mboskamp mboskamp marked this pull request as ready for review September 19, 2024 14:27
@mboskamp
Copy link
Member Author

mboskamp commented Sep 20, 2024 •
edited
Loading

It does not look like it's necessary to put the batchId into the persistentState of the JobEntity.

@ Reviewer, let me know if you disagree.

danielkelemen
danielkelemen requested changes Sep 20, 2024
View reviewed changes
Copy link
Member

@danielkelemen danielkelemen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice job.
Added two nitpicks and one column is in the wrong table.

engine/src/main/java/org/camunda/bpm/engine/history/HistoricJobLog.java Outdated Show resolved Hide resolved
engine/src/main/java/org/camunda/bpm/engine/impl/jobexecutor/JobDeclaration.java Outdated Show resolved Hide resolved
engine/src/main/resources/org/camunda/bpm/engine/db/create/activiti.mariadb.create.history.sql Outdated Show resolved Hide resolved
engine/src/test/java/org/camunda/bpm/engine/test/history/JobEntityAndJobLogBatchIdTest.java Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice tests

danielkelemen
danielkelemen approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@danielkelemen danielkelemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Approving to save time with the condition that the column is in the right table and CI is green.

@mboskamp mboskamp merged commit 0188c9e into master Sep 20, 2024
1 check was pending
@mboskamp mboskamp deleted the 4206-batchid-job-joblog branch September 20, 2024 16:02
@mboskamp
Copy link
Member Author

The CI stages that failed without the last fix passed successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkelemen danielkelemen danielkelemen approved these changes

Assignees

@mboskamp mboskamp

Labels
ci:all-db Runs the builds for all databases.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mboskamp @danielkelemen