feat(oauth2): add sso logout support #4604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielkelemen
added
ci:run
|
I added some details in the corresponding issue: #4455 |
venetrius
reviewed
Sep 18, 2024
...ot-starter/starter-security/src/main/resources/plugin-webapp/sso-logout-plugin/app/plugin.js
Outdated
Show resolved
Hide resolved
...ot-starter/starter-security/src/main/resources/plugin-webapp/sso-logout-plugin/app/plugin.js
Outdated
Show resolved
Hide resolved
danielkelemen
force-pushed
the
4455-oauth2-sso-logout
branch
from
4548c10
to
f51fb32
Compare
yanavasileva
approved these changes
Sep 19, 2024
...da/bpm/spring/boot/starter/security/oauth2/CamundaSpringSecurityOAuth2AutoConfiguration.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Enable SSO Logout. Default {@code {baseUrl}}. | ||
| */ | ||
| private String postLogoutRedirectUri = "{baseUrl}"; |
There was a problem hiding this comment.
✍️ In docs, we need to add that this must be provided if sso-logout is enabled. At least for Okta, this property is mandatory.
| /** | ||
| * Enable SSO Logout. Default {@code false}. | ||
| */ | ||
| private boolean enabled = false; |
There was a problem hiding this comment.
✍️ We need to document this and default value.
danielkelemen
commented
Sep 19, 2024
|
|
||
| var validateTokenFilter = new AuthorizeTokenFilter(clientManager); |
There was a problem hiding this comment.
🔧 Refactored this so it uses the same @Bean structure as other classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4455