Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate identity provider automatically when passing --oauth2 #4583

Closed
1 task done
Tracked by #4450
tasso94 opened this issue Sep 6, 2024 · 1 comment
Closed
1 task done
Tracked by #4450

Activate identity provider automatically when passing --oauth2 #4583

tasso94 opened this issue Sep 6, 2024 · 1 comment
Assignees
Labels
type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue. version:7.22.0-alpha6 version:7.22.0

Comments

@tasso94
Copy link
Member

tasso94 commented Sep 6, 2024

Acceptance Criteria (Required on creation)

Activate identity provider automatically when passing --oauth2.

Hints

Make configuring camunda.bpm.oauth2.identity-provider.enabled: true for Camunda Run obsolete when passing the --oauth2 flag.

Links

Breakdown

Pull Requests

  1. danielkelemen
@tasso94 tasso94 added type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue. version:7.22.0 labels Sep 6, 2024
@danielkelemen
Copy link
Member

danielkelemen commented Sep 20, 2024

Possible Solutions

  1. Pass the configuration in the startup script.
    java.jar ... --camunda.bpm.oauth2.identity-provider.enabled=true
    • Pros: Easy
    • Cons: After testing it, it looks like yaml cannot override this anymore. Customers could only change it by manually changing the start.sh script.
  2. Have a Run configuration that always registers the provider.
    • In Spring Boot we could check if provider is already registered, so it's not registered twice.
    • Pros: ?
    • Cons: Not easily overridable either.
  3. Register the Identity Provider by default.
    • Change default to true: identity-provider.enabled=true
    • OAuth2 is likely used with groups, too so it makes sense.
    • Pros: Easiest
    • Cons: Nothing, users can still disable it if they wish.

Decision: 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue. version:7.22.0-alpha6 version:7.22.0
Projects
None yet
Development

No branches or pull requests

4 participants