Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Spring Framework to a version = 5.3.39 = 6.0.23, and >= 6.1.13 #4551

Closed
7 tasks done
tasso94 opened this issue Aug 21, 2024 · 7 comments
Closed
7 tasks done

Bump Spring Framework to a version = 5.3.39 = 6.0.23, and >= 6.1.13 #4551

tasso94 opened this issue Aug 21, 2024 · 7 comments
Assignees
Labels
type:task Issues that are a change to the project that is neither a feature nor a bug fix. version:7.20.9 version:7.21.6 version:7.22.1 version:7.23.0-alpha1 version:7.23.0

Comments

@tasso94
Copy link
Member

tasso94 commented Aug 21, 2024

Acceptance Criteria (Required on creation)

Bump Spring Framework to a version >= 5.3.40, >= 6.0.24, and >= 6.1.13.

Hints

Links

Breakdown

Pull Requests

  1. bot:backport:7.20 bot:backport:7.21 bot:backport:7.22 bot:java-dependency-check ci:all-as ci:e2e ci:spring-boot ci:wildfly
    mboskamp
  2. bot:backport:7.22 bot:java-dependency-check ci:all-as ci:spring-boot scope:spring-boot
    mboskamp

Dev2QA handover

  • Does this ticket need a QA test and the testing goals are not clear from the description? Add a Dev2QA handover comment
@tasso94 tasso94 added type:task Issues that are a change to the project that is neither a feature nor a bug fix. version:7.23.0 potential:7.22.1 potential:7.21.6 potential:7.20.9 labels Aug 21, 2024
@tasso94 tasso94 changed the title Bump Spring Framework to a version >= 5.3.39 Bump Spring Framework to a version >= 5.3.39, >= 6.0.23, and >= 6.1.12 Aug 21, 2024
@tasso94 tasso94 changed the title Bump Spring Framework to a version >= 5.3.39, >= 6.0.23, and >= 6.1.12 Bump Spring Framework to a version >= 5.3.39, >= 6.0.24, and >= 6.1.13 Sep 24, 2024
@mboskamp mboskamp changed the title Bump Spring Framework to a version >= 5.3.39, >= 6.0.24, and >= 6.1.13 Bump Spring Framework to a version >= 5.3.40, >= 6.0.24, and >= 6.1.13 Oct 8, 2024
@mboskamp mboskamp changed the title Bump Spring Framework to a version >= 5.3.40, >= 6.0.24, and >= 6.1.13 Bump Spring Framework to a version = 5.3.39 = 6.0.23, and >= 6.1.13 Oct 8, 2024
@mboskamp
Copy link
Member

mboskamp commented Oct 8, 2024

Spring versions >=6.0.24 and >=5.3.40 will only be available for Spring enterprise customers (Source).

There is no CE upgrade path for Spring 5.3.x. We have the following options:

  • Upgrade
    • Necessary actions:
      • Move away from Spring Framework 5.3.x.
    • Pro
      • Only one Spring Framework version needs to be maintained
      • Up-to-date Spring Framework version for all components without the need for Spring EE support license
    • Con
      • Higher migration effort
  • Accept risk
    • Necessary actions:
      • Risk analysis
      • Document the security risk
      • Document users should have Spring EE support license and use the latest 5.3.x version
    • Pro
      • Less migration effort
    • Con
      • It will not be possible for us to test the patch versions >5.3.39
      • Users might miss the documentation and use a potentially vulnerable version

Decision:
We will

  • use 5.3.39 (the latest CE release)
  • inform those customers who use environments using 5.3.x to
    • get EE support for Spring
    • build the affected artifacts themselves

@yanavasileva
Copy link
Member

@mboskamp, I think we should bump the Spring Boot version too otherwise the Spring Framework version used in Starter and Run remains old patch.
https://github.com/camunda/automation-platform-vulnerability-scan/issues/3696

mboskamp added a commit that referenced this issue Oct 28, 2024
@mboskamp
Copy link
Member

I have added PRs for master (automatic backport to 7.22) and 7.21 (see list above). For 7.20, we are already on the newest version (3.1.12).

@mboskamp mboskamp assigned tasso94 and joaquinfelici and unassigned mboskamp and tasso94 Oct 29, 2024
@tasso94
Copy link
Member Author

tasso94 commented Oct 29, 2024

Hey @mboskamp, Spring 6.1.14 was released two weeks ago. Can we bump to it right away?

@mboskamp
Copy link
Member

@tasso94, the Spring Framework PRs have been merged for three weeks. Currently, this ticket is about bumping the Spring Boot version as well because it affects the Spring Framework version in those components.
Of course, I can revisit the Spring Framework PRs, but it feels like a moving target.

@mboskamp
Copy link
Member

@tasso94, I created a follow-up issue for bumping the versions again just before the next patch release.
#4751

@mboskamp
Copy link
Member

All Spring Boot PRs merged.

hauptmedia added a commit to hauptmedia/operaton that referenced this issue Nov 5, 2024
Related to camunda/camunda-bpm-platform#4551

Backported commit 1e800652da from the camunda-bpm-platform repository.
Original author: Miklas Boskamp <[email protected]>
javahippie pushed a commit to operaton/operaton that referenced this issue Nov 6, 2024
Related to camunda/camunda-bpm-platform#4551

Backported commit 1e800652da from the camunda-bpm-platform repository.
Original author: Miklas Boskamp <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:task Issues that are a change to the project that is neither a feature nor a bug fix. version:7.20.9 version:7.21.6 version:7.22.1 version:7.23.0-alpha1 version:7.23.0
Projects
None yet
Development

No branches or pull requests

5 participants