feat(core) Add update and delete command Java/Rest APIs #4333

prajwolbhandari1 · 2024-05-13T16:03:11Z

DELETE /task/{taskId}/comment/{commentId}
deletes a comment of a given taskId and commentId
DELETE /task/{taskId}/comment
deletes all comments of a given taskId
PUT /task/comment
updates a comment
DELETE /process-instance/{processInstanceId}/comment/{commentId}
deletes a comment of a given processInstanceId and commentId
DELETE /process-instance/{processInstanceId}/comment.
deletes all comments of a given processInstanceId
PUT /process-instance/comment
updates a comment

related to: #2551

…Instance DELETE /task/{taskId}/comment/{commentId} - deletes a comment of a given taskId and commentId DELETE /task/{taskId}/comment - deletes all comments of a given taskId PUT /task/comment - updates a comment DELETE /process-instance/{processInstanceId}/comment/{commentId} - deletes a comment of a given processInstanceId and commentId DELETE /process-instance/{processInstanceId}/comment. - deletes all comments of a given processInstanceId PUT /process-instance/comment - updates a comment related to: camunda#2551

…nd processInstance DELETE /task/{taskId}/comment/{commentId} - deletes a comment of a given taskId and commentId DELETE /task/{taskId}/comment - deletes all comments of a given taskId PUT /task/comment - updates a comment DELETE /process-instance/{processInstanceId}/comment/{commentId} - deletes a comment of a given processInstanceId and commentId DELETE /process-instance/{processInstanceId}/comment. - deletes all comments of a given processInstanceId PUT /process-instance/comment - updates a comment related to: camunda#2551

…k and processInstance DELETE /task/{taskId}/comment/{commentId} - deletes a comment of a given taskId and commentId DELETE /task/{taskId}/comment - deletes all comments of a given taskId PUT /task/comment - updates a comment DELETE /process-instance/{processInstanceId}/comment/{commentId} - deletes a comment of a given processInstanceId and commentId DELETE /process-instance/{processInstanceId}/comment. - deletes all comments of a given processInstanceId PUT /process-instance/comment - updates a comment related to: camunda#2551

yanavasileva · 2024-05-17T06:14:27Z

Hi @prajwolbhandari1,

Thank you for raising this.
We will have a look and get back to you. As the changes are a lot it might take some time to cover everything.

Best,
Yana

yanavasileva · 2024-05-17T08:22:44Z

Note to myself:

docs for user operation logs and authorizations

prajwol123 · 2024-06-12T12:49:16Z

@yanavasileva any update on this?

yanavasileva · 2024-06-13T14:20:01Z

Thank you for your patience with this.
I didn't have the time to start with the review yet. I will get to it next week.

yanavasileva

👍 The changes look good as a start.
Unfortunately, more aspects need to be covered, I left comments below. One more general note:
❌ There's a lot of code duplication in the code of the commands. Please merge the commands (for PI and task) similarly to DeleteAttachmentCmd. That way, the maintenance of the code will be easier.

...ne/src/main/java/org/camunda/bpm/engine/impl/persistence/entity/UserOperationLogManager.java

yanavasileva · 2024-06-14T07:36:23Z

engine/src/main/java/org/camunda/bpm/engine/history/UserOperationLogEntry.java

✍️ The new user operation logs must be documented here: https://docs.camunda.org/manual/latest/user-guide/process-engine/history/user-operation-log/#glossary-of-operations-logged-in-the-user-operation-log
Could you please raise a PR in the docs repo? (page)

engine/src/main/java/org/camunda/bpm/engine/impl/persistence/entity/CommentEntity.java

engine/src/main/java/org/camunda/bpm/engine/TaskService.java

engine/src/main/java/org/camunda/bpm/engine/impl/cfg/CommandChecker.java

engine/src/main/java/org/camunda/bpm/engine/impl/cfg/auth/AuthorizationCommandChecker.java

engine/src/main/java/org/camunda/bpm/engine/impl/cfg/multitenancy/TenantCommandChecker.java

engine/src/main/java/org/camunda/bpm/engine/impl/cmd/DeleteProcessInstanceCommentCmd.java

engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/Comment.xml

prajwolbhandari1 · 2024-06-19T20:11:00Z

thank you @yanavasileva. I will work on these changes as soon as possible.

- add revision to comments - change authorization to task_assign from task_update - refactor code - add more java docs

…/update comments

Signed-off-by: Bhandari, Prajwol <[email protected]>

github-actions · 2024-07-12T04:05:13Z

Closing due to lack of requested feedback. If you would like us to look at this, please provide the requested information to re-open the PR.

prajwol123 · 2024-07-12T05:46:44Z

I am done with all changes. I will raise PR as soon as possible. Sent from my iPhoneOn Jul 11, 2024, at 10:05 PM, github-actions[bot] ***@***.***> wrote: Closed #4333. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>

yanavasileva · 2024-07-12T06:29:20Z

@prajwolbhandari1, you can continue the work in this one, I reopened it for you.

prajwolbhandari1 · 2024-08-07T15:28:20Z

@yanavasileva just pushed changes

yanavasileva

I started the review and to avoid losing the progress, I am posting my comments so far.

engine/src/main/resources/org/camunda/bpm/engine/db/upgrade/db2_engine_7.21_to_7.22.sql

engine/src/main/resources/org/camunda/bpm/engine/db/upgrade/mariadb_engine_7.21_to_7.22.sql

engine/src/main/resources/org/camunda/bpm/engine/db/upgrade/mssql_engine_7.21_to_7.22.sql

engine/src/main/java/org/camunda/bpm/engine/impl/cmd/DeleteProcessInstanceCommentCmd.java

engine/src/main/java/org/camunda/bpm/engine/impl/cmd/DeleteTaskCommentCmd.java

engine/src/main/java/org/camunda/bpm/engine/impl/cmd/UpdateCommentCmd.java

engine/src/main/java/org/camunda/bpm/engine/TaskService.java

yanavasileva · 2024-08-28T18:36:52Z

...c/test/java/org/camunda/bpm/engine/test/api/encoding/ProcessEngineCharacterEncodingTest.java

👍 Good one.

prajwolbhandari1

@yanavasileva thanks for the review. Are you done reviewing the PR? If you are, I can quickly make these good feedbacks. Please let me know. Thanks again.

prajwolbhandari1 · 2024-09-03T18:01:34Z

...ne/src/main/java/org/camunda/bpm/engine/impl/persistence/entity/UserOperationLogManager.java

@yanavasileva what exactly do you mean by size limit?

prajwolbhandari1 · 2024-09-07T04:39:38Z

@yanavasileva thanks for the review. Are you done reviewing the PR? If you are, I can quickly make these good feedbacks. Please let me know. Thanks again.

Let me know what u think. I want to wait till you are done with your review.

yanavasileva

I am done with the review, please proceed with adjustments.

Pay attention to these important findings:

link
link
some of the test cases where for standalone tasks, we need to cover task part of process instances too.

Heads up, we approach the minor release code freeze.
❗ If you want the feature to be included in 7.22.0, please apply the feedback by 19th of September. I will try to check it on time and merge accordingly.

When you are ready with the changes. I kindly ask you to:

run the engine test suite: mvn clean install -f engine/pom.xml
run the engine-rest tests: mvn clean install -Pjersey2 -f engine-rest/engine-rest/pom.xml
If tests are green, request a new review for the PR.

...ne-rest/src/main/java/org/camunda/bpm/engine/rest/sub/task/impl/TaskCommentResourceImpl.java

...in/java/org/camunda/bpm/engine/rest/sub/runtime/impl/ProcessInstanceCommentResourceImpl.java

...rc/test/java/org/camunda/bpm/engine/test/api/authorization/TaskCommentAuthorizationTest.java

...a/org/camunda/bpm/engine/test/api/authorization/ProcessInstanceCommentAuthorizationTest.java

engine/src/main/java/org/camunda/bpm/engine/impl/cmd/DeleteProcessInstanceCommentCmd.java

engine/src/main/java/org/camunda/bpm/engine/impl/cmd/UpdateCommentCmd.java

engine/src/main/java/org/camunda/bpm/engine/impl/cmd/DeleteProcessInstanceCommentCmd.java

- fix verbiage in ftl files - add standalone tests for delete comment(s) by process instance id and task id - fix/rewrite sql statement - write additional process instance tests - few minor changes

prajwolbhandari1 · 2024-09-16T23:44:00Z

I am preparing for the changes. Pushing the changes soon.

prajwolbhandari1 · 2024-09-17T16:03:50Z

@yanavasileva FYI, just pushed my changes.

yanavasileva · 2024-09-20T15:51:32Z

The branch has conflicts. Could you please resolve them, it will easy the review process.

# Conflicts: # engine/src/main/resources/org/camunda/bpm/engine/db/upgrade/db2_engine_7.21_to_7.22.sql # engine/src/main/resources/org/camunda/bpm/engine/db/upgrade/h2_engine_7.21_to_7.22.sql # engine/src/main/resources/org/camunda/bpm/engine/db/upgrade/mariadb_engine_7.21_to_7.22.sql # engine/src/main/resources/org/camunda/bpm/engine/db/upgrade/mssql_engine_7.21_to_7.22.sql # engine/src/main/resources/org/camunda/bpm/engine/db/upgrade/mysql_engine_7.21_to_7.22.sql # engine/src/main/resources/org/camunda/bpm/engine/db/upgrade/oracle_engine_7.21_to_7.22.sql # engine/src/main/resources/org/camunda/bpm/engine/db/upgrade/postgres_engine_7.21_to_7.22.sql

prajwol123 · 2024-09-20T17:45:29Z

The branch has conflicts. Could you please resolve them, it will easy the review process.

will do as soon as possible

prajwolbhandari1 · 2024-09-20T20:11:11Z

The branch has conflicts. Could you please resolve them, it will easy the review process.

will do as soon as possible

@yanavasileva FYI, Resolved conflicts.

prajwol123 · 2024-09-25T16:42:02Z

@yanavasileva any update on this?

Feel free to make any necessary minor adjustments if it will help speed up the code merge for the upcoming release.

yanavasileva · 2024-09-26T16:33:43Z

Hi Team,

Unfortunately, the feature won't make the cut for the 7.22 release.

@prajwol123 / @prajwolbhandari1

Feel free to make any necessary minor adjustments if it will help speed up the code merge for the upcoming release.

Please note, that all Fidelity branches can't be adjusted by us, the fork don't allow edits. So it's not so easy to do even minor changes on the code of your contributions. If you want you can reconsider to enable editing.

Best,
Yana

prajwol123 · 2024-09-26T16:48:34Z

Hi Team,

Unfortunately, the feature won't make the cut for the 7.22 release.

@prajwol123 / @prajwolbhandari1

Feel free to make any necessary minor adjustments if it will help speed up the code merge for the upcoming release.

Please note, that all Fidelity branches can't be adjusted by us, the fork don't allow edits. So it's not so easy to do even minor changes on the code of your contributions. If you want you can reconsider to enable editing.

Best,

Yana

Hey, no worries. Thank you for your help. Let's shoot for next release. Please let me know what you think about the latest code changes.

prajwol123 · 2024-11-02T12:16:06Z

Any updates on this ? @yanavasileva

prajwol123 · 2024-11-14T13:54:00Z

any ideas ? @yanavasileva

prajwolbhandari1 added 4 commits May 2, 2024 08:46

chore(engine) added git issue number in newly created files.

c307a42

prajwolbhandari1 mentioned this pull request May 13, 2024

Java and Rest API supports update and delete of task and process instance comments #2551

Open

yanavasileva assigned prajwolbhandari1 May 17, 2024

yanavasileva self-requested a review May 17, 2024 07:37

yanavasileva requested changes Jun 14, 2024

View reviewed changes

yanavasileva added the group:requested-info DRI: Yana label Jun 14, 2024

github-actions bot added the group:stale DRI: Yana label Jun 15, 2024

github-actions bot added group:stale DRI: Yana and removed group:stale DRI: Yana labels Jun 20, 2024

feat(engine)

b7d5510

- add revision to comments - change authorization to task_assign from task_update - refactor code - add more java docs

github-actions bot removed the group:stale DRI: Yana label Jun 27, 2024

yanavasileva changed the title ~~feat(engine, engine-rest-core, engine-rest-openapi) Add update and delete Java/Rest APIs of task and processInstance~~ feat(core) Add update and delete command Java/Rest APIs Jun 27, 2024

feat(engine) update task_assign authorization to task_work for delete…

92eb6b0

…/update comments

github-actions bot added the group:stale DRI: Yana label Jun 28, 2024

Merge branch 'master' into finalRepoCommentsApis

18b3aeb

Signed-off-by: Bhandari, Prajwol <[email protected]>

github-actions bot added group:stale DRI: Yana and removed group:stale DRI: Yana labels Jul 3, 2024

github-actions bot added the group:closed-as-inactive DRI: Yana label Jul 12, 2024

github-actions bot closed this Jul 12, 2024

yanavasileva reopened this Jul 12, 2024

yanavasileva removed group:requested-info DRI: Yana group:closed-as-inactive DRI: Yana group:stale DRI: Yana labels Jul 12, 2024

delete cockroachdb files

89004ed

yanavasileva self-requested a review August 13, 2024 07:17

yanavasileva reviewed Aug 28, 2024

View reviewed changes

prajwolbhandari1 commented Sep 3, 2024

View reviewed changes

yanavasileva self-requested a review September 7, 2024 10:34

yanavasileva requested changes Sep 7, 2024

View reviewed changes

prajwolbhandari1 added 2 commits September 11, 2024 00:25

Feedback Adjustments

ac5f84b

- fix verbiage in ftl files - add standalone tests for delete comment(s) by process instance id and task id - fix/rewrite sql statement - write additional process instance tests - few minor changes

Fix engine-rest tests

970ec8d

yanavasileva self-requested a review September 17, 2024 17:44

prajwolbhandari1 added 2 commits September 20, 2024 10:22

Fix merge conflicts with master

2d65b7f

Merge branch 'master' into finalRepoCommentsApis

b3b1eeb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core) Add update and delete command Java/Rest APIs #4333

feat(core) Add update and delete command Java/Rest APIs #4333

prajwolbhandari1 commented May 13, 2024

yanavasileva commented May 17, 2024

yanavasileva commented May 17, 2024

prajwol123 commented Jun 12, 2024

yanavasileva commented Jun 13, 2024

yanavasileva left a comment

yanavasileva Jun 14, 2024

prajwolbhandari1 commented Jun 19, 2024

github-actions bot commented Jul 12, 2024

prajwol123 commented Jul 12, 2024 via email

yanavasileva commented Jul 12, 2024

prajwolbhandari1 commented Aug 7, 2024

yanavasileva left a comment

yanavasileva Aug 28, 2024

prajwolbhandari1 left a comment

prajwolbhandari1 Sep 3, 2024

prajwolbhandari1 commented Sep 7, 2024

yanavasileva left a comment •

edited

Loading

prajwolbhandari1 commented Sep 16, 2024

prajwolbhandari1 commented Sep 17, 2024

yanavasileva commented Sep 20, 2024

prajwol123 commented Sep 20, 2024

prajwolbhandari1 commented Sep 20, 2024

prajwol123 commented Sep 25, 2024

yanavasileva commented Sep 26, 2024

prajwol123 commented Sep 26, 2024

prajwol123 commented Nov 2, 2024

prajwol123 commented Nov 14, 2024

feat(core) Add update and delete command Java/Rest APIs #4333

Are you sure you want to change the base?

feat(core) Add update and delete command Java/Rest APIs #4333

Conversation

prajwolbhandari1 commented May 13, 2024

yanavasileva commented May 17, 2024

yanavasileva commented May 17, 2024

prajwol123 commented Jun 12, 2024

yanavasileva commented Jun 13, 2024

yanavasileva left a comment

Choose a reason for hiding this comment

yanavasileva Jun 14, 2024

Choose a reason for hiding this comment

prajwolbhandari1 commented Jun 19, 2024

github-actions bot commented Jul 12, 2024

prajwol123 commented Jul 12, 2024 via email

yanavasileva commented Jul 12, 2024

prajwolbhandari1 commented Aug 7, 2024

yanavasileva left a comment

Choose a reason for hiding this comment

yanavasileva Aug 28, 2024

Choose a reason for hiding this comment

prajwolbhandari1 left a comment

Choose a reason for hiding this comment

prajwolbhandari1 Sep 3, 2024

Choose a reason for hiding this comment

prajwolbhandari1 commented Sep 7, 2024

yanavasileva left a comment • edited Loading

Choose a reason for hiding this comment

prajwolbhandari1 commented Sep 16, 2024

prajwolbhandari1 commented Sep 17, 2024

yanavasileva commented Sep 20, 2024

prajwol123 commented Sep 20, 2024

prajwolbhandari1 commented Sep 20, 2024

prajwol123 commented Sep 25, 2024

yanavasileva commented Sep 26, 2024

prajwol123 commented Sep 26, 2024

prajwol123 commented Nov 2, 2024

prajwol123 commented Nov 14, 2024

yanavasileva left a comment •

edited

Loading