Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the "Quick Start" Getting Started Guide #4252

Closed
Tracked by #4279
github-actions bot opened this issue Apr 8, 2024 · 3 comments
Closed
Tracked by #4279

Migrate the "Quick Start" Getting Started Guide #4252

github-actions bot opened this issue Apr 8, 2024 · 3 comments
Assignees
Labels
group:release type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue. version:7.22.0

Comments

@github-actions
Copy link

github-actions bot commented Apr 8, 2024

Acceptance Criteria (Required on creation)

  • All Screenshots are up to date
  • It works with the new release version
  • Code Examples in the docs use the new release version
  • Source Code in solution repository uses the new release version (version will be updated via Jenkins job on the official release date)
  • Ensure latest versions of java/javascript external task worker dependencies
  • The license header of java files is updated
  • Update the NOTICE file if necessary (bump the year if it's the first release of the year)

Resources

Hints

Links

Breakdown

@github-actions github-actions bot added group:release type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue. version:7.22.0 labels Apr 8, 2024
@psavidis psavidis assigned venetrius and unassigned venetrius Sep 25, 2024
@venetrius
Copy link
Member

Updated code:

  • updated worker.js to use ES type imports to resolve error:
[Error [ERR_REQUIRE_ESM]: require() of ES Module not supported](https://stackoverflow.com/questions/69081410/error-err-require-esm-require-of-es-module-not-supported)
  • update package.json to include "type": "module", for above reason

Updated docs:

  • Updated min NodeJS to v16.x
  • Updated docs to integrate code changes

@venetrius
Copy link
Member

@danielkelemen
Could you review the changes in this commit?

@venetrius venetrius assigned danielkelemen and unassigned venetrius Sep 26, 2024
@danielkelemen
Copy link
Member

👍 Docs and get-started-quickstart repo look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group:release type:subtask Issues that are subtasks of another issue. Must always be part of the breakdown of the parent issue. version:7.22.0
Projects
None yet
Development

No branches or pull requests

2 participants