-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Configuration of Duplicate Filtering in Camunda Run #2652
Comments
This comment was imported from JIRA and written by user @tmetzke Hey @jonathanlukas, thanks for creating this proposal. We'll look into it as soon as possible and get back with proper feedback. Best, |
This comment was imported from JIRA and written by user @tmetzke Hey @jonathanlukas, thanks again for bringing this up. I think this makes a lot of sense in the scope of the product. I will forward your proposal to product management to consider this in our roadmap planning. In order to make an informed decision on the priority, please let us know if there are any existing (customer) use cases you are aware of that would benefit from this. Best, |
Add documentation for property `camunda.bpm.run.deploymentdeploy-changed-only` Related-to: camunda/camunda-bpm-platform#2652
Description: The feature allows camunda-run to parameterise the filtering of duplicate resources via a configurable flag. Feature-flag: This commit introduces the new feature flag `camunda.bpm.run.deployment.deploy-changed-only` Default-value: `true` (to be backwards compatible with the previously hardcoded behaviour) Has-refactoring: This commit also refactors the `@CamundaBpmRunConfiguration` and all its dependencies to be simpler and conforming to spring-boot best practices. Has-unit-tests: This commit adds three test cases for covering the enabling | Disabling | Absence of the new property. Related-to: #2652
Where: `User Guide | Camunda 7 Run` What - Section `Deployment` - Property `camunda.bpm.run.deployment.deploy-changed-only` Related-to: camunda/camunda-bpm-platform#2652
The code and documentation are done. Assigning the ticket to @gbetances089 for doing the QA tests (see Dev2QA handover section) |
Verified on |
Description: The feature allows camunda-run to parameterise the filtering of duplicate resources via a configurable flag. Feature-flag: This commit introduces the new feature flag `camunda.bpm.run.deployment.deploy-changed-only` Default-value: `true` (to be backwards compatible with the previously hardcoded behaviour) Has-refactoring: This commit also refactors the `@CamundaBpmRunConfiguration` and all its dependencies to be simpler and conforming to spring-boot best practices. Has-unit-tests: This commit adds three test cases for covering the enabling | Disabling | Absence of the new property. Related-to: camunda/camunda-bpm-platform#2652 Backported commit e7941a3f50 from the camunda-bpm-platform repository. Original author: psavidis <[email protected]>"
Description: The feature allows camunda-run to parameterise the filtering of duplicate resources via a configurable flag. Feature-flag: This commit introduces the new feature flag `camunda.bpm.run.deployment.deploy-changed-only` Default-value: `true` (to be backwards compatible with the previously hardcoded behaviour) Has-refactoring: This commit also refactors the `@CamundaBpmRunConfiguration` and all its dependencies to be simpler and conforming to spring-boot best practices. Has-unit-tests: This commit adds three test cases for covering the enabling | Disabling | Absence of the new property. Related-to: camunda/camunda-bpm-platform#2652 Backported commit e7941a3f50 from the camunda-bpm-platform repository. Original author: psavidis <[email protected]>"
This issue was imported from JIRA:
User Story (Required on creation):
As a system administrator, I want Camunda Run to be configurable regarding filtering of resource deployments so that I can properly deploy resources that depend on each other inside one deployment.
Functional Requirements (Required before implementation):
Technical Requirements (Required before implementation):
Limitations of Scope (Optional):
This only applies to Camunda Platform Run
Hints (optional):
Links:
Breakdown
Code & Docs
Dev2QA handover
Testing instructions:
The
deployChangedOnly=true
flag is currently populated indefault.yml
,production.yml
.The goal of this testing is to ensure that the the configuration and the behaviour of filtering resources works in
camunda-run
. Please find below two test cases that verify the above, along with example steps to follow for doing the testing.Scenario # 1
deployChangedOnly
is set totrue
, Then a resource of a deployment without changes should not be redeployed upon restart/camunda-bpm-platform/distro/run/distro/target/camunda-bpm-run-7.22.0-SNAPSHOT/
foldertext1.txt
-> "This is text1",text2.txt
-> "This is text2"start.sh
)SpringAutoDeployment
should exist under deployments containing both files.shutdown.sh
)text1.txt
SpringAutoDeployment
should exist that contains only the changed resourcetext1.txt
Scenario # 2
deployChangedOnly
is set tofalse
, Then all resources of a deployment should be redeployed upon a restart/camunda-bpm-platform/distro/run/distro/target/camunda-bpm-run-7.22.0-SNAPSHOT/
foldertext1.txt
-> "This is text1",text2.txt
-> "This is text2"start.sh
)SpringAutoDeployment
should exist under deployments containing both files.camunda-run
(invokeshutdown.sh
)text1.txt
SpringAutoDeployment
should exist that contains both filestext1.txt
andtext2.txt
, despite that onlytext1.txt
changedThe text was updated successfully, but these errors were encountered: