-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is it a separate extension? #19
Comments
Hi Simon (@zambrovski) The main reason I started a separate project is that I wanted to keep it as lean as possible (to be able to easily maintain and support it). So this project is really "just" providing the OpenAPI code - and not trying to hide this behind the embedded-engine classes (like RuntimeService). So from my perspective, I think it is quite OK to have both projects as they simply do different things (expose OpenAPI vs. mimicking the RuntimeService but delegating to REST). So if you agree I would close this issue - the only thing I would see for now is that we might want to add something to the readme about it? Best |
Hi Bernd! Hmm. To be honest - I don't like it. We are currently implementing the same things twice... You probably had to deal with incompatibilities of the OpenAPI generator and some request/response patterns used in Camunda Platform 7 REST API, and we had to deal with it too... My approach would be to create one extension producing several libraries:
This would be much more clear for the user and having the same code base, the user can just decide what library to use... What do you think? Cheers, Simon |
But the REST API is not complete,eg.deleteCandidateUser |
Hey guys,
we already have an official Camunda Platform 7 extension called camunda-rest-client-spring-boot building a Java client embedded in SpringBoot. In it's core it is creating the client and in addition it wraps into the implementations of the Camunda Java API. So you might choose between a Java API provided by the generated client or Camunda Java API (Runtime Service, Task Service, etc...)
Would it make sense to unify the work on those extension into one project?
Cheers,
Simon
The text was updated successfully, but these errors were encountered: