From 482e5c58a493cdd12b183bcd8ac6874f9c56c44f Mon Sep 17 00:00:00 2001 From: Camila Macedo Date: Thu, 29 Aug 2024 19:35:40 +0100 Subject: [PATCH] (go/v4): remove the typecheck due the false positives The typecheck start to complain against many case scenarios. It might be a bug in the current version. So, we are removing it and we can revisit this decision in the future --- docs/book/src/cronjob-tutorial/testdata/project/.golangci.yml | 1 - docs/book/src/getting-started/testdata/project/.golangci.yml | 1 - pkg/plugins/golang/v4/scaffolds/internal/templates/golangci.go | 1 - testdata/project-v4-multigroup-with-deploy-image/.golangci.yml | 1 - testdata/project-v4-multigroup/.golangci.yml | 1 - testdata/project-v4-with-deploy-image/.golangci.yml | 1 - testdata/project-v4-with-grafana/.golangci.yml | 1 - testdata/project-v4/.golangci.yml | 1 - 8 files changed, 8 deletions(-) diff --git a/docs/book/src/cronjob-tutorial/testdata/project/.golangci.yml b/docs/book/src/cronjob-tutorial/testdata/project/.golangci.yml index aac8a13f928..46b95300c89 100644 --- a/docs/book/src/cronjob-tutorial/testdata/project/.golangci.yml +++ b/docs/book/src/cronjob-tutorial/testdata/project/.golangci.yml @@ -36,7 +36,6 @@ linters: - prealloc - revive - staticcheck - - typecheck - unconvert - unparam - unused diff --git a/docs/book/src/getting-started/testdata/project/.golangci.yml b/docs/book/src/getting-started/testdata/project/.golangci.yml index aac8a13f928..46b95300c89 100644 --- a/docs/book/src/getting-started/testdata/project/.golangci.yml +++ b/docs/book/src/getting-started/testdata/project/.golangci.yml @@ -36,7 +36,6 @@ linters: - prealloc - revive - staticcheck - - typecheck - unconvert - unparam - unused diff --git a/pkg/plugins/golang/v4/scaffolds/internal/templates/golangci.go b/pkg/plugins/golang/v4/scaffolds/internal/templates/golangci.go index f4376036ae4..5dd239ad9d1 100644 --- a/pkg/plugins/golang/v4/scaffolds/internal/templates/golangci.go +++ b/pkg/plugins/golang/v4/scaffolds/internal/templates/golangci.go @@ -80,7 +80,6 @@ linters: - prealloc - revive - staticcheck - - typecheck - unconvert - unparam - unused diff --git a/testdata/project-v4-multigroup-with-deploy-image/.golangci.yml b/testdata/project-v4-multigroup-with-deploy-image/.golangci.yml index aac8a13f928..46b95300c89 100644 --- a/testdata/project-v4-multigroup-with-deploy-image/.golangci.yml +++ b/testdata/project-v4-multigroup-with-deploy-image/.golangci.yml @@ -36,7 +36,6 @@ linters: - prealloc - revive - staticcheck - - typecheck - unconvert - unparam - unused diff --git a/testdata/project-v4-multigroup/.golangci.yml b/testdata/project-v4-multigroup/.golangci.yml index aac8a13f928..46b95300c89 100644 --- a/testdata/project-v4-multigroup/.golangci.yml +++ b/testdata/project-v4-multigroup/.golangci.yml @@ -36,7 +36,6 @@ linters: - prealloc - revive - staticcheck - - typecheck - unconvert - unparam - unused diff --git a/testdata/project-v4-with-deploy-image/.golangci.yml b/testdata/project-v4-with-deploy-image/.golangci.yml index aac8a13f928..46b95300c89 100644 --- a/testdata/project-v4-with-deploy-image/.golangci.yml +++ b/testdata/project-v4-with-deploy-image/.golangci.yml @@ -36,7 +36,6 @@ linters: - prealloc - revive - staticcheck - - typecheck - unconvert - unparam - unused diff --git a/testdata/project-v4-with-grafana/.golangci.yml b/testdata/project-v4-with-grafana/.golangci.yml index aac8a13f928..46b95300c89 100644 --- a/testdata/project-v4-with-grafana/.golangci.yml +++ b/testdata/project-v4-with-grafana/.golangci.yml @@ -36,7 +36,6 @@ linters: - prealloc - revive - staticcheck - - typecheck - unconvert - unparam - unused diff --git a/testdata/project-v4/.golangci.yml b/testdata/project-v4/.golangci.yml index aac8a13f928..46b95300c89 100644 --- a/testdata/project-v4/.golangci.yml +++ b/testdata/project-v4/.golangci.yml @@ -36,7 +36,6 @@ linters: - prealloc - revive - staticcheck - - typecheck - unconvert - unparam - unused