? #2210
Closed
? #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More progress towards #2067! This PR takes a stab at tweaking `docs/frontends/queues.md` to incorporate additions from PRs #2164 and #2174. --------- Co-authored-by: Anshuman Mohan <[email protected]>
This PR makes progress towards #1810. It implements the python oracle for PIFOs generalized to n flows, now known as Round Robin queues. Just as with the PIFO, if a flow falls silent, the remaining flows will take their turns. That flow effectively skips its turn. To re-generate the test files with 20000 commands and a max length of 16, type in the command line after navigating to the directory calyx/calyx-py/calyx ``` ./gen_queue_data_expect.sh ``` Additionally, this PR also implements the Calyx version of Round Robin queues in rr_queue.py. This was originally supposed to be its own PR, but I thought it might be more complicated if I branched off a branch. To run these tests, type in the command line ``` runt -i "rr_queue" ``` --------- Co-authored-by: Cassandra Nicole Sziklai <[email protected]> Co-authored-by: Anshuman Mohan <[email protected]> Co-authored-by: Anshuman Mohan <[email protected]>
It looks like `calyx-py/test/correctness/queues/*.py` was removed from the path of its runt test by #2177: i.e. the old `fifo`, `pifo`, and `pifo_tree` tests aren't running at CI. Was this intentional? In case it wasn't, I've made a minor fix to `runt.toml`.
Automatically `cargo clippy` and others before you commit
This PR ties off the last half of #1810. It implements the python oracle and Calyx eDSL for strict PIFOs, which are generalized to n flows. Flows have a strict order of priority, which determines popping and peeking order. If the highest priority flow is silent when it is its turn, that flow simply skips its turn and the next flow is offered service. If that higher priority flow get pushed to in the interim, the next call to pop/peek will return from that flow. To re-generate the test files with 20000 commands and a max length of 16, type in the command line after navigating to the directory calyx/calyx-py/calyx ``` ./gen_queue_data_expect.sh ``` To run the runt tests on the eDSL implementation, type ``` runt -i "strict" ``` --------- Co-authored-by: Cassandra Nicole Sziklai <[email protected]> Co-authored-by: Anshuman Mohan <[email protected]> Co-authored-by: Anshuman Mohan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.