[fud2] Several more tests #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to #1954. And part of #1878.
Just adds a bunch more tests to fud2 using the setup I created recently. Now every op in fud2 is covered except for
primitive-uses; this should probably be covered once we have a more complete FIRRTL pipeline in here that depends on it.(Incidentally, I had to look around for code coverage tools for Rust. I found I liked llvm-cov more than the more popular tarpaulin. The main problem I had with the latter is that I couldn't filter out all the rest of the source files—so there was this giant list of source files with 0% coverage from the rest of the entire Calyx workspace. Surely there is a flag to just focus on one crate/subdirectory, but I couldn't find it? Anyway, llvm-cov did the right thing by default.)